WIO_BG96: fix macro exclusion - use cellular #14424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on cellular drivers not netsockets (it works because both are present in the system, not true when you use CMake).
|
@ARMmbed/team-st-mcd did I miss something why nsapi was used instead of cellular? |
|
Sorry, I don't know TARGET_WIO_BG96 |
|
I see. I checked git blame. This was maintained mainly but cellular team. |
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
|
This target is own by @ARMmbed/team-seeed |
hugueskamba
approved these changes
Mar 16, 2021
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
the
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on cellular drivers not netsockets (it works because both are present in
the system, not true when you use CMake).
Summary of changes
I've noticed the on board modem was using netsockets present and not cellular while reviewing similar driver.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers