Fix missing linkage of mbed-mbedtls-cryptocell310 to mbed-mbedtls #14435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
previously approved these changes
Mar 16, 2021
0xc0170
added
the
release-type: patch
hugueskamba
approved these changes
Mar 17, 2021
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
The failure is related. to my understanding: mbedtls is not enabled in CMake, build fails. This will work for examples that link to mbedtls, but not for apps that do not need mbedtls. We looked at this briefly but haven't found a solution. It's known issue. A target can add additional libraries, in this case tls as the driver requires it, but should it be linked always? An app can choose what to link to, but what about a target. |
|
@0xc0170 In other Mbed TLS drivers we simply add the driver code as part of mbed-mbedtls. I can do that. |
LDong-Arm
force-pushed
the
CRYPTOCELL310_linking
branch
from
2321e8e to
29474cf
Compare
LDong-Arm
force-pushed
the
CRYPTOCELL310_linking
branch
from
29474cf to
2228aa7
Compare
|
@0xc0170 Done |
The CMake target mbed-mbedtls-cryptocell310 was not linked by
default, resulting in a compilation error on targets that use
Mbed TLS:
fatal error: mbedtls_device.h: No such file or directory
Other Mbed TLS drivers simply add themselve to mbed-mbedtls, so this
commits does the alignment to fix the build error.
Note: the driver and the core Mbed TLS have mutual dependency, so
they need to be one CMake target.
LDong-Arm
force-pushed
the
CRYPTOCELL310_linking
branch
from
2228aa7 to
4c6f886
Compare
0xc0170
approved these changes
Apr 7, 2021
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The CMake target mbed-mbedtls-cryptocell310 was not linked by default, resulting in a compilation error on targets that use
Mbed TLS:
Other Mbed TLS drivers simply add themselve to mbed-mbedtls, so this commits does the alignment to fix the build error.
Note: the driver and the core Mbed TLS have mutual dependency, so they need to be one CMake target.
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers
@0xc0170 @hugueskamba @rajkan01