Maxim: Add bare metal support to targets #14465

harmut01 · 2021-03-24T15:33:44Z

Summary of changes

Add heap load region to scatter file and update targets.json to
provide baremetal support to the following targets: SDT32620B,
SDT32625B, MAX32620FTHR, MAX32625MBED, MAX32625PICO,
and MAX32630FTHR.

Impact of changes

Maxim targets

Migration actions required

None

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2021-03-24T16:00:25Z

@harmut01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

targets/TARGET_Maxim/TARGET_MAX32620C/device/TOOLCHAIN_ARM_STD/MAX32620.sct

targets/TARGET_Maxim/TARGET_MAX32625/device/TOOLCHAIN_ARM_STD/TARGET_MAX32625_BOOT/MAX32625.sct

hugueskamba · 2021-03-24T16:21:29Z

...s/TARGET_Maxim/TARGET_MAX32625/device/TOOLCHAIN_ARM_STD/TARGET_MAX32625_NO_BOOT/MAX32625.sct

        *.o (RESET, +First)
        *(InRoot$$Sections)
        .ANY (+RO)
    }

    ; [RAM] Vector table dynamic copy: 68 vectors * 4 bytes = 272 (0x110)
-    RW_IRAM1 (0x20000000+0x110) (0x28000-0x110-Stack_Size)  {  ; RW data
+    RW_IRAM1 (MBED_RAM_START+VECTOR_SIZE) (MBED_RAM_SIZE-VECTOR_SIZE-Stack_Size)  {  ; RW data


Suggested change

RW_IRAM1 (MBED_RAM_START+VECTOR_SIZE) (MBED_RAM_SIZE-VECTOR_SIZE-Stack_Size) { ; RW data

RW_IRAM1 (MBED_RAM_START+VECTOR_SIZE) (MBED_RAM_SIZE-MBED_RAM_FIXED_SIZE) { ; RW data

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct

targets/targets.json

ahmetalincak · 2021-03-24T16:29:59Z

Thanks for the changes. I also worked on this issue and have a merged PR #14080 . I guess I missed this SDT32620B target. Also I haven't changed the scatter files. Do they really have effect on behavior? @harmut01

harmut01 · 2021-03-24T16:51:33Z

@ahmetalincak the main change in the scatter files is the addition of heap load regions, this is intended to enable the ARM compiler to build with the small c library. The remaining are largely to make the scatter files consistent with those in other targets (see this for example).

harmut01 · 2021-03-24T16:54:38Z

I've update the title to more accurately reflect the changes.

hugueskamba · 2021-03-24T16:56:35Z

Thanks for the changes. I also worked on this issue and have a merged PR #14080 . I guess I missed this SDT32620B target. Also I haven't changed the scatter files. Do they really have effect on behavior? @harmut01

Microlib does not support selectable one or two region memory models as the standard library (stdlib) does.
Microlib provides only the two region memory model with separate stack and heap regions.

Source: https://developer.arm.com/documentation/dui0475/m/the-arm-c-micro-library/differences-between-microlib-and-the-default-c-library

hugueskamba · 2021-03-25T12:45:08Z

This PR adds bare-metal support for both ARM and GCC_ARM unlike what the title says.

hugueskamba · 2021-03-25T14:19:08Z

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct

-    ARM_LIB_STACK (0x20000000+0x80000) EMPTY -Stack_Size { ; stack
+    ARM_LIB_HEAP AlignExpr(+0, +16) EMPTY (MBED_RAM_SIZE - RAM_FIXED_SIZE - (AlignExpr(ImageLimit(RW_IRAM1), 16) - MBED_RAM_START)){ ; heap growing up
+    }
+    ARM_LIB_STACK (MBED_RAM_START+MBED_RAM_SIZE) EMPTY -Stack_Size { ; stack


Suggested change

ARM_LIB_STACK (MBED_RAM_START+MBED_RAM_SIZE) EMPTY -Stack_Size { ; stack

ARM_LIB_STACK (MBED_RAM_START+MBED_RAM_SIZE) EMPTY -Stack_Size { ; stack growing down

Add heap load region to scatter file and update `targets.json` to provide baremetal support to the following targets: SDT32620B, SDT32625B, MAX32620FTHR, MAX32625MBED, MAX32625PICO, and MAX32630FTHR.

adbridge · 2021-03-29T13:27:16Z

@hugueskamba could you please re-review based on the updates.

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct

hugueskamba

LGTM (assuming you attempted to build one of the Mbed targets affected by the linker file changes).

harmut01 · 2021-04-12T10:46:52Z

@0xc0170 can we start CI on this?

0xc0170 · 2021-04-12T11:54:29Z

CI started

mbed-ci · 2021-04-12T12:48:50Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	❌

harmut01 · 2021-04-12T13:25:55Z

@0xc0170 it appears CI timed out on while running mbed-os-example-crash-reporting for an unrelated target.

0xc0170 · 2021-04-15T10:21:50Z

CI restarted

mbed-ci · 2021-04-15T11:38:44Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

ahmetalincak

Please re-review this commit to fix MBED MAXIM parts for ARMC6 compiler.

@0xc0170 @harmut01 @hugueskamba

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct

harmut01 requested review from hugueskamba, 0xc0170 and a team March 24, 2021 15:34

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 24, 2021

ciarmcom requested a review from a team March 24, 2021 16:00

ciarmcom added needs: review devices: maxim labels Mar 24, 2021

hugueskamba reviewed Mar 24, 2021

View reviewed changes

harmut01 changed the title ~~Maxim: Add bare metal support to targets~~ Maxim: Add bare metal support to targets for Arm Compiler 6 Mar 24, 2021

harmut01 force-pushed the baremetal_maxim branch from 3c749a3 to 1902cf9 Compare March 25, 2021 09:45

harmut01 changed the title ~~Maxim: Add bare metal support to targets for Arm Compiler 6~~ Maxim: Add bare metal support to targets Mar 25, 2021

harmut01 requested a review from hugueskamba March 25, 2021 14:14

hugueskamba reviewed Mar 25, 2021

View reviewed changes

harmut01 requested a review from hugueskamba March 26, 2021 09:06

harmut01 force-pushed the baremetal_maxim branch from 1902cf9 to 81dec68 Compare March 26, 2021 09:06

Maxim: Add bare metal support to targets

3d1051d

Add heap load region to scatter file and update `targets.json` to provide baremetal support to the following targets: SDT32620B, SDT32625B, MAX32620FTHR, MAX32625MBED, MAX32625PICO, and MAX32630FTHR.

harmut01 force-pushed the baremetal_maxim branch from 81dec68 to 3d1051d Compare March 26, 2021 09:07

hugueskamba requested changes Mar 31, 2021

View reviewed changes

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct Outdated Show resolved Hide resolved

Refactor RW_IRAM1 load region definition

3d66447

harmut01 requested a review from hugueskamba March 31, 2021 13:24

hugueskamba requested changes Mar 31, 2021

View reviewed changes

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct Outdated Show resolved Hide resolved

Refactor ER_IROM1 load region defintion

18d8499

harmut01 requested a review from hugueskamba March 31, 2021 15:28

0xc0170 added needs: work and removed needs: review labels Apr 6, 2021

harmut01 force-pushed the baremetal_maxim branch from 5ebdf6d to 8a98c5e Compare April 7, 2021 09:59

Refactor definition of heap load region start

1c671c4

harmut01 force-pushed the baremetal_maxim branch from 8a98c5e to 1c671c4 Compare April 7, 2021 13:27

hugueskamba approved these changes Apr 7, 2021

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Apr 12, 2021

mergify bot added needs: work and removed needs: CI labels Apr 12, 2021

0xc0170 added needs: CI and removed needs: work labels Apr 15, 2021

0xc0170 approved these changes Apr 15, 2021

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Apr 15, 2021

0xc0170 merged commit 016d725 into ARMmbed:master Apr 15, 2021

mergify bot removed the ready for merge label Apr 15, 2021

mbedmain added release-version: 6.10.0 Release-pending labels Apr 16, 2021

mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021

idea--list mentioned this pull request Jun 8, 2021

MAX32630FTHR throws Mutex error #14712

Closed

ahmetalincak reviewed Mar 13, 2022

View reviewed changes

targets/TARGET_Maxim/TARGET_MAX32630/device/TOOLCHAIN_ARM_STD/MAX3263x.sct Outdated Show resolved Hide resolved

ahmetalincak mentioned this pull request Mar 14, 2022

USB Serial for MAX32630 and MAX32625 devices - previously working in OS6.7 not working in current versions of OS6 #15237

Closed

	RW_IRAM1 (MBED_RAM_START+VECTOR_SIZE) (MBED_RAM_SIZE-VECTOR_SIZE-Stack_Size) { ; RW data
	RW_IRAM1 (MBED_RAM_START+VECTOR_SIZE) (MBED_RAM_SIZE-MBED_RAM_FIXED_SIZE) { ; RW data

	ARM_LIB_STACK (MBED_RAM_START+MBED_RAM_SIZE) EMPTY -Stack_Size { ; stack
	ARM_LIB_STACK (MBED_RAM_START+MBED_RAM_SIZE) EMPTY -Stack_Size { ; stack growing down

Maxim: Add bare metal support to targets #14465

Maxim: Add bare metal support to targets #14465

Uh oh!

Conversation

harmut01 commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Mar 24, 2021

Uh oh!

Uh oh!

Uh oh!

hugueskamba Mar 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ahmetalincak commented Mar 24, 2021

Uh oh!

harmut01 commented Mar 24, 2021

Uh oh!

harmut01 commented Mar 24, 2021

Uh oh!

hugueskamba commented Mar 24, 2021

Uh oh!

hugueskamba commented Mar 25, 2021

Uh oh!

hugueskamba Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

adbridge commented Mar 29, 2021

Uh oh!

Uh oh!

Uh oh!

hugueskamba left a comment

Choose a reason for hiding this comment

Uh oh!

harmut01 commented Apr 12, 2021

Uh oh!

0xc0170 commented Apr 12, 2021

Uh oh!

mbed-ci commented Apr 12, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

harmut01 commented Apr 12, 2021

Uh oh!

0xc0170 commented Apr 15, 2021

Uh oh!

mbed-ci commented Apr 15, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

ahmetalincak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

harmut01 commented Mar 24, 2021 •

edited

Loading

ahmetalincak left a comment •

edited

Loading