Skip to content

CMake COMPONENT_BlueNRG_MS: fix mbed-ble #14486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix ARMmbed/mbed-os-example-ble#364

BLE component was not compiled for:

  • DISCO_L562QE
  • DISCO_L475VG_IOT01A
  • B_L4S5I_IOT01A

@boraozgen

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 30, 2021
@ciarmcom ciarmcom requested a review from a team March 30, 2021 09:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@boraozgen
Copy link
Contributor

Fixes the issue. I would also apply this to other controllers (BlueNRG_2 etc.) and remove the mbed-ble-blue_nrg target from mbed-os/connectivity CMake file.

BTW during testing with DISCO_L562QE and BLE_GattServer_CharacteristicWrite example, I noticed that sometimes it hangs after Ble process started.. It starts working after a couple resets. Seems totally random. Any ideas?

@jeromecoutant
Copy link
Collaborator Author

Fixes the issue. I would also apply this to other controllers (BlueNRG_2 etc.) and remove the mbed-ble-blue_nrg target from mbed-os/connectivity CMake file.

@hugueskamba @0xc0170
Maybe you could provide a global correction and close this one ?

0xc0170
0xc0170 previously requested changes Apr 6, 2021
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite the commit - this is fixing an error - fixing the target (mbed-ble) rather than cli2 support (related).

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2021

Maybe you could provide a global correction and close this one ?

Yes, we can do. Let's close this one and create a new issue about this. @jeromecoutant Can you create new issue? i'll triage it.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2021

mbed-ble-blue_nrg target from mbed-os/connectivity CMake file.

@jeromecoutant Can this fix this component and we can fix others separately?

@jeromecoutant
Copy link
Collaborator Author

You can start CI or close this one and make a better one!
Up to you !

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2021

I'll start CI, please also remove mbed-ble-blue_nrg from connectivity as stated above (add_library is there).

@mergify mergify bot dismissed 0xc0170’s stale review April 7, 2021 10:04

Pull request has been modified.

@jeromecoutant jeromecoutant changed the title COMPONENT_BlueNRG_MS: MBED CLI2 support [CMAKE] COMPONENT_BlueNRG_MS: fix mbed-ble Apr 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2021

I see force push but I do not see add_library(mbed-ble-blue_nrg INTERFACE) removed from connectivity/CMakeLists.txt

@jeromecoutant
Copy link
Collaborator Author

I see force push but I do not see add_library(mbed-ble-blue_nrg INTERFACE) removed from connectivity/CMakeLists.txt

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

cI restarted

@0xc0170 0xc0170 changed the title [CMAKE] COMPONENT_BlueNRG_MS: fix mbed-ble CMake: COMPONENT_BlueNRG_MS: fix mbed-ble Apr 14, 2021
@0xc0170 0xc0170 changed the title CMake: COMPONENT_BlueNRG_MS: fix mbed-ble CMake COMPONENT_BlueNRG_MS: fix mbed-ble Apr 14, 2021
@mbed-ci
Copy link

mbed-ci commented Apr 14, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit bedd572 into ARMmbed:master Apr 14, 2021
@mergify mergify bot removed the ready for merge label Apr 14, 2021
@jeromecoutant jeromecoutant deleted the PR_CLI2_BLE branch April 14, 2021 14:31
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mbed CLI 2 not linking BlueNrg HCI drivers
6 participants