-
Notifications
You must be signed in to change notification settings - Fork 3k
CMake COMPONENT_BlueNRG_MS: fix mbed-ble #14486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, thank you for your changes. |
Fixes the issue. I would also apply this to other controllers (BlueNRG_2 etc.) and remove the BTW during testing with |
@hugueskamba @0xc0170 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rewrite the commit - this is fixing an error - fixing the target (mbed-ble) rather than cli2 support (related).
Yes, we can do. Let's close this one and create a new issue about this. @jeromecoutant Can you create new issue? i'll triage it. |
@jeromecoutant Can this fix this component and we can fix others separately? |
You can start CI or close this one and make a better one! |
I'll start CI, please also remove mbed-ble-blue_nrg from connectivity as stated above (add_library is there). |
cad5dcc
to
c82979a
Compare
I see force push but I do not see |
c82979a
to
57ce710
Compare
Done |
cI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Fix ARMmbed/mbed-os-example-ble#364
BLE component was not compiled for:
@boraozgen
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers