Skip to content

make target list for applications in examples_cmake.json consistent with examples.json #14507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2021
Merged

make target list for applications in examples_cmake.json consistent with examples.json #14507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa2a067
update cmake_examples to latest CI passing list
saheerb Apr 15, 2021
a62cd22
disable test for example-device-key
saheerb Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tools/test/examples/cloud_examples_cmake.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,38 @@
"baud_rate": 115200,
"compare_log": ["mbed-os-example-for-aws/tests/aws.log"],
"auto-update" : true
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we delete cloud_examples_cmake.json in this PR? CI can use cloud_examples.json without running into failures, even for CMake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that. It's easier to update the cloud_examples_cmake.json for now as it involves no change in CI scripts. We can delete the examples_cmake.json and cloud_examples_cmake.json together?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we should. When can we do it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have all the examples passing in cmake. Now just one left, mbed-os-example-mesh-minimal

{
"name": "mbed-os-example-for-azure",
"github": "https://github.com/ARMmbed/mbed-os-example-for-azure",
"sub-repo-example": false,
"subs": [],
"features" : [],
"targets" : ["DISCO_L475VG_IOT01A", "K64F", "NUCLEO_F429ZI"],
"toolchains" : [],
"exporters": [],
"compile" : true,
"export": true,
"test" : false,
"baud_rate": 115200,
"compare_log": ["mbed-os-example-for-azure/tests/azure.log"],
"auto-update" : true
},
{
"name": "mbed-os-example-for-google-iot-cloud",
"github": "https://github.com/ARMmbed/mbed-os-example-for-google-iot-cloud",
"sub-repo-example": false,
"subs": [],
"features" : [],
"targets" : ["DISCO_L475VG_IOT01A", "K64F", "NUCLEO_F429ZI"],
"toolchains" : [],
"exporters": [],
"compile" : true,
"export": true,
"test" : false,
"baud_rate": 115200,
"compare_log": ["mbed-os-example-for-google-iot-cloud/tests/google-iot-cloud.log"],
"auto-update" : true
}
]
}
Loading