Add cmake unittest fakes for BLE and events #14515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new MbedOS project in mbed os root CMake which can be used along with BUILD_TESTING conditional check for enabling the unittest build - Update UNITTEST CMake for setting the CMake configuration like c, cxx flags etc., - Add if CMAKE_CROSSCOMPILING conditional check wherever target configuration check and toolchain configuration to avoid such configuration gets included for unittest build.
- add every libraries unittest directory into respective CMake which allows to include unittest source into build based on MBED_BUILD_UNITTESTS flag
- Remove the readme as it is a duplicate content of official document https://os.mbed.com/docs/mbed-os/v6.9/debug-test/unit-testing.html
|
@paul-szczepanek-arm, thank you for your changes. |
pan-
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
The mocks are correct and setting default roles in the absence of configuration for unit test necessary.
Thanks for the changes @paul-szczepanek-arm
rajkan01
force-pushed
the
feature_unittest_refactor
branch
from
efd2180 to
32cd073
Compare
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
rajkan01
force-pushed
the
feature_unittest_refactor
branch
13 times, most recently
from
300f135 to
8944fc4
Compare
rajkan01
force-pushed
the
feature_unittest_refactor
branch
15 times, most recently
from
a610d79 to
3ed97b1
Compare
|
This pull request has automatically been marked as stale because it has had no recent activity. @paul-szczepanek-arm, please carry out any necessary work to get the changes merged. Thank you for your contributions. |
rajkan01
force-pushed
the
feature_unittest_refactor
branch
from
960b2c6 to
10625b3
Compare
|
replaced by #14737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This adds fakes for unittests for BLE and events. This requires a change in roles configurations for the roles to default to on so that unittests don't need to manually set the configs.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers