Tests: use only NUCLEO_F401RE for the NFC examples #14527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository mbed-os-example-nfc contains two examples: NFC_EEPROM and NFC_SmartPoster. According to their respective `mbed_app.json`, only NUCLEO_F401RE supports both examples, so we limit the compilation test to this target only. Compilation with an unsupported target fails (as expected) with Mbed CLI 2 which enforces a check on a target's availability of the required NFC controller. Mbed CLI 1 lacks such check and always compiles. Fixes ARMmbed/mbed-os-example-nfc#106
0xc0170
approved these changes
Apr 9, 2021
|
There is already an update for cmake examples: #14507 (note, we got examples split at the moment, 2 json, they will be united once we make all green. This is changing the config for only cli1, is that the intention and 14507 fixes CMake one. |
|
@0xc0170 Thanks, I'll add a comment to that PR. |
Patater
approved these changes
Apr 9, 2021
0xc0170
added
the
release-type: patch
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The repository mbed-os-example-nfc contains two examples: NFC_EEPROM and NFC_SmartPoster. According to their respective
mbed_app.json, only NUCLEO_F401RE supports both examples, so we limit the compilationtest to this target only.
Compilation with an unsupported target fails (as expected) with Mbed CLI 2 which enforces a check on a target's availability of the required NFC controller (PN512). Mbed CLI 1 lacks such check and always compiles the NFC controller's driver regardless of the target.
Fixes ARMmbed/mbed-os-example-nfc#106
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-core