Cmake: Add MBED_TEST_MODE macro #14538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@harmut01, thank you for your changes. |
|
Adding a test as well here? |
|
Yes, I'm working on making a test project now 👍🏿 |
harmut01
force-pushed
the
cmake-test-mode
branch
2 times, most recently
from
177fea2 to
a25fcdc
Compare
|
I need to add a step to install mbed-tools in |
harmut01
force-pushed
the
cmake-test-mode
branch
5 times, most recently
from
ee1b8b1 to
d69b2ef
Compare
Patater
previously requested changes
Apr 15, 2021
Patater
previously requested changes
Apr 16, 2021
|
@Patater looks like the "Extended" hiding of cmake isn't sufficient, i'll try and move it into the cmake job. |
LDong-Arm
reviewed
Apr 16, 2021
LDong-Arm
reviewed
Apr 16, 2021
LDong-Arm
suggested changes
Apr 19, 2021
Fixes ARMmbed#14494 MBED_TEST_MODE is required for backward compatibilty with CLI1. This adds a test to ensure that the macro is created when using CLI2 for testing. This also adds a test in `.travis.yml` that checks whether CMake defines the macro when BUILD_TESTING is on. CLI1 Reference: https://os.mbed.com/docs/mbed-os/v6.9/debug-test/greentea-for-testing-applications.html Also, explicitly create and set the macro BUILD_TESTING to allow for MBED_TEST_MODE to be defined by CMake. MBED_TEST_MODE is required for backward compatibilty with CLI1. BUILD_TESTING is used to determine whether to define MBED_TEST_MODE. Normally, this would be automatically done by CTest (which we intend to add for test automation) but this hasn't yet been added to our Greentea tests.
harmut01
force-pushed
the
cmake-test-mode
branch
from
d148cf2 to
c29b561
Compare
|
@harmut01 Are you able to fix Travis failures ? |
|
yes @0xc0170, I'll take a look at it today. |
The default distribution of CMake that comes with focal is 3.16.3. Add kitware's repository (https://apt.kitware.com/) to the source list so the latest copy of CMake is installed during CI.
Patater
approved these changes
May 5, 2021
0xc0170
approved these changes
May 6, 2021
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #14494
MBED_TEST_MODE was used in CLI1 to prevent multiple applications from
being built. Add the macro to provide backward compatibility, along with a test
application.
Impact of changes
None
Migration actions required
None
Documentation
CLI1 Reference: https://os.mbed.com/docs/mbed-os/v6.9/debug-test/greentea-for-testing-applications.html
Pull request type
Test results
Reviewers