Skip to content

Increase baud rate of mbed-os-example-crash-reporting to 115200 #14541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2021
Merged

Increase baud rate of mbed-os-example-crash-reporting to 115200 #14541

merged 1 commit into from
Apr 14, 2021

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Apr 13, 2021 •
edited
Loading

Summary of changes

At 9600 baud, a large part of the serial output of the crash reporting example is missing on CI boards, causing the example test to fail. At a higher serial speed (115200 baud), the entire output is intact.

This is in alignment with ARMmbed/mbed-os-example-crash-reporting#65.

Fixes #14535

Impact of changes

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @saheerb @ARMmbed/mbed-os-core

@LDong-Arm
Increase baud rate of mbed-os-example-crash-reporting to 115200
b5893be 
At 9600 baud, a large part of the serial output of the crash reporting
example is missing on CI boards, causing the example test to fail. At
a higher serial speed (115200 baud), the entire output is intact.

This is in alignment with ARMmbed/mbed-os-example-crash-reporting#65.

Fixes ARMmbed#14535
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 13, 2021
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@0xc0170 @saheerb @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from 0xc0170, saheerb and a team April 13, 2021 15:30
@LDong-Arm LDong-Arm mentioned this pull request Apr 14, 2021
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 14, 2021
@LDong-Arm
Copy link
Contributor Author

Is this change enough to build and run the example with baud rate 115200? Or does it depend on ARMmbed/mbed-os-example-crash-reporting#65 for building?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

I would expect the baud_rate in testing .json to overwrite what is in the example but lets wait for @saheerb to confirm.

@saheerb
Copy link
Contributor

saheerb commented Apr 14, 2021

Is this change enough to build and run the example with baud rate 115200? Or does it depend on ARMmbed/mbed-os-example-crash-reporting#65 for building?

Yea, we need both. The baud rate in examples.json is used only for opening connection.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

Oh ok, so first we need to get example updated to get green here.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

Although the examples passed, but that is due to not always hitting the error.

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Apr 14, 2021
@LDong-Arm
Copy link
Contributor Author

Although the examples passed, but that is due to not always hitting the error.

It did fail, because of the baud rate mismatch. I'm working to get Travis passing in ARMmbed/mbed-os-example-crash-reporting#65.

@Patater
Copy link
Contributor

Patater commented Apr 14, 2021

We've merged ARMmbed/mbed-os-example-crash-reporting#65, so this PR needs to be tested and merged soon.

@Patater
Copy link
Contributor

Patater commented Apr 14, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@LDong-Arm
Copy link
Contributor Author

I double checked the CI results, and now we're getting the full log of mbed-os-example-crash-reporting.

@0xc0170 0xc0170 merged commit a3be10c into ARMmbed:master Apr 14, 2021
@mergify mergify bot removed the ready for merge label Apr 14, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@saheerb saheerb saheerb approved these changes

Assignees
No one assigned
Labels
component: tools release-version: 6.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serial outputs of mbed-os-example-crash-reporting trimmed in CI
7 participants
@LDong-Arm @ciarmcom @0xc0170 @saheerb @mbed-ci @Patater @mbedmain