Fix missing as_entry method in KVStoreSecurityDb
#14684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces changes to fix a missing method, `as_entry`, and traces that were not updated properly to work with this new method. Prior to this fix, it was not possible to use KVStoreSecurityDb as the build would fail since the `as_entry` method was not declared in the class header file. This bug was introduced with commit 957486e in PR ARMmbed#14198
ciarmcom
added
the
release-type: patch
|
@AGlass0fMilk, thank you for your changes. |
paul-szczepanek-arm
approved these changes
May 20, 2021
pan-
approved these changes
May 20, 2021
ghost
approved these changes
May 20, 2021
There was a problem hiding this comment.
This PR fixes BLE_SecurityAndPrivacy CLI 1 builds, so party addresses #14660.
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
adbridge
approved these changes
May 24, 2021
mbedmain
added
release-version: 6.12.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This commit introduces changes to fix a missing method,
as_entry, and traces that were not updated properly to work with this new method.Prior to this fix, it was not possible to use KVStoreSecurityDb as the build would fail since the
as_entrymethod was not declared in the class header file.This bug was introduced with commit 957486e in PR #14198
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@pan- @paul-szczepanek-arm @noonfom @ladislas
Perhaps we should add a test for this build configuration?