Skip to content

Separating build and test results in upload script #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions workspace_tools/upload_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,19 +174,20 @@ def add_project_run(projectRuns, project):

elem[project['project']] = project

def update_project_run_results(project_to_update, project):
project_to_update['pass'] = project['pass']
project_to_update['result'] = project['result']

if 'buildOutput' in project:
def update_project_run_results(project_to_update, project, is_build):
if is_build:
project_to_update['buildPass'] = project['buildPass']
project_to_update['buildResult'] = project['buildResult']
project_to_update['buildOutput'] = project['buildOutput']
else:
project_to_update['testPass'] = project['testPass']
project_to_update['testResult'] = project['testResult']
project_to_update['testOutput'] = project['testOutput']

def update_project_run(projectRuns, project):
def update_project_run(projectRuns, project, is_build):
found_project = find_project_run(projectRuns, project)
if found_project:
update_project_run_results(found_project, project)
update_project_run_results(found_project, project, is_build)
else:
add_project_run(projectRuns, project)

Expand Down Expand Up @@ -245,18 +246,27 @@ def add_report(project_run_data, report_file, is_build, build_id, host_os):

errors = test_case.findall('error')
failures = test_case.findall('failure')
projectRunPass = None
result = None

if errors:
projectRun['pass'] = False
projectRun['result'] = errors[0].attrib['message']
projectRunPass = False
result = errors[0].attrib['message']
elif failures:
projectRun['pass'] = False
projectRun['result'] = failures[0].attrib['message']
projectRunPass = False
result = failures[0].attrib['message']
else:
projectRunPass = True
result = 'OK'

if is_build:
projectRun['buildPass'] = projectRunPass
projectRun['buildResult'] = result
else:
projectRun['pass'] = True
projectRun['result'] = 'OK'
projectRun['testPass'] = projectRunPass
projectRun['testResult'] = result

update_project_run(project_run_data['projectRuns'], projectRun)
update_project_run(project_run_data['projectRuns'], projectRun, is_build)

def main(arguments):
# Register and parse command line arguments
Expand Down