Skip to content

Move connectivity cellular stubs #14834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2021
Merged

Move connectivity cellular stubs #14834

merged 3 commits into from
Jun 30, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jun 28, 2021 •
edited
Loading

Summary of changes

fixes #14794

  • Moved the connectivity cellular into the connectivity/cellular component directory and added CMake for creating a new mbed-stubs-cellular stubs library, previously cellular stubs sources part of mbed-stubs-connectivity lib
  • Previously all cellular header made as a part of the mbed-headers-connectivity library. To make it easier to separate all the cellular headers into the separate mbed-headers-cellular library and keep them as part of cellular stub CMake. This makes the cellular stubs more self-contained and improves the composition of the library.
  • Updated all unit test that depends on cellular headers with mbed-headers-cellular library
  • Previously the connectivity cellular stub library depended on mbed-headers, which is a collection of all available headers in mbed-os. To make it easier to separate the library, only depend on the headers it uses.

Impact of changes

None.

Migration actions required

None

Documentation

To be updated

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 28, 2021
@ciarmcom ciarmcom requested a review from a team June 28, 2021 09:30
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@rajkan01 rajkan01 force-pushed the move_connectivity_cellular_stubs branch from 9a209c4 to 474e9fa Compare June 28, 2021 11:06
LDong-Arm
LDong-Arm previously approved these changes Jun 29, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Jun 29, 2021
rwalton-arm
rwalton-arm previously approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@rwalton-arm rwalton-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 30, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ❌

@rajkan01 rajkan01 force-pushed the move_connectivity_cellular_stubs branch from 474e9fa to 7acd11f Compare June 30, 2021 12:21
@mergify mergify bot dismissed stale reviews from LDong-Arm and rwalton-arm June 30, 2021 12:22

Pull request has been modified.

LDong-Arm
LDong-Arm reviewed Jun 30, 2021
View reviewed changes
rajkan01 added 3 commits June 30, 2021 06:01
@rajkan01
CMake: Move connectivity/cellular stubs to the mbed-os/connectivity/c…
fa0ab53 
…ellular dir

Move the connectivity cellular into the connectivity/cellular component
directory. So we can avoid duplicating the mbed-os source tree in a
central UNITTESTS folder.
@rajkan01
CMake: unit-tests: Add mbed-headers-cellular headers library
ee67310 
- Previously all cellular header made as a part of the
mbed-headers-connectivity library. To make it easier to separate all
the cellular headers into the separate mbed-headers-cellular library
and keep them as part of cellular stub CMake. This makes the cellular
stubs more self-contained and improves the composition of the library.
- Update all unit test that depends on cellular headers with mbed-headers-cellular library
@rajkan01
CMake: unit-tests: Make cellular stub only depend on headers it uses
d8add9e 
Previously the connectivity cellular stub library depended on
`mbed-headers`, which is a collection of all available headers
in mbed-os. To make it easier to separate the library, only depend
on the headers we're using.
@rajkan01 rajkan01 force-pushed the move_connectivity_cellular_stubs branch from 7acd11f to d8add9e Compare June 30, 2021 13:01
@LDong-Arm
Copy link
Contributor

@rajkan01 Before your latest force pushes, Jenkins CI failed but Travis passed if I remember correctly. Maybe Jenkins uses CLI 1 (mbed test --unittests), it would be good to try it locally?

@rajkan01
Copy link
Contributor Author

@rajkan01 Before your latest force pushes, Jenkins CI failed but Travis passed if I remember correctly. Maybe Jenkins uses CLI 1 (mbed test --unittests), it would be good to try it locally?

@LDong-Arm I always tried mbed test --unittests command locally before pushing the changes, but I don't know how this got missed

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 30, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@rajkan01 rajkan01 requested a review from LDong-Arm June 30, 2021 14:49
LDong-Arm
LDong-Arm approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajkan01 Thanks. LGTM.

@mergify mergify bot removed the needs: CI label Jun 30, 2021
@LDong-Arm
Copy link
Contributor

@ARMmbed/mbed-os-maintainers For PRs related to unit test stubs, shall we do CI + merge one PR at a time (instead of all in parallel), as rebase after merge conflicts is needed quite often.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 30, 2021

I'll coordinate with Raj

@0xc0170 0xc0170 merged commit 022b5a2 into master Jun 30, 2021
@mergify mergify bot removed the ready for merge label Jun 30, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
@0xc0170 0xc0170 deleted the move_connectivity_cellular_stubs branch October 5, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@rwalton-arm rwalton-arm rwalton-arm left review comments

Assignees
No one assigned
Labels
component: connectivity component: test release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move cellular stubs to Connectivity/cellular directory
7 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @rwalton-arm @mbedmain