[STM B96B_F446VE] Add CAN feature #1520

adustm · 2016-01-29T13:32:51Z

can_api is now supported with platform B96B_F446VE
MBED_A27 (loopback test) is passing.
can and can_interrupt tests are passing (only 1 can is available on this platform pins).

Some more tests were passed : I plugged can1 from B96B_F446VE board on another board's CAN transmitter, a non-crossed DB9 wire and another CAN-enabled STM board.
. can loopback iteration
. can_rx
. can tx
. can Rx+Tx
. can Rx with interrupt

Cheers

0xc0170 · 2016-01-30T16:29:35Z

libraries/mbed/hal/can_api.h

@@ -37,7 +37,8 @@ typedef enum {
    IRQ_PASSIVE,
    IRQ_ARB,
    IRQ_BUS,
-    IRQ_READY
+    IRQ_READY,
+    IRQ_RX1


What's this new type error? I dont see this in the commit message

Hello, I just comitted this file again, explaining the new interrupt in the commit message.
There are 2 fifos in CAN. Each fifo generates its own interrupt in case of reception / fifo-full or overrun.
Adding a new value to the enum should have no effect on other microcontrollers.

What CAN are you referring to ? stm32 CAN peripheral module? Isn't this STM32 specific?

You're right it is specific to STM32. We would have liked to get IRQ_RX0 and IRQ_RX1, but I did not want to change existing code for other partners.
I only added a new define.
Some of the current enum are not used in our board. Isn't IRQ_ARB specific to another module ? It shouldn't be an issue as long as it is an enum and everyone implements a 'default' case.

Hello @0xc0170,
I can remove RX1 interrupt. It will take longer to receive 2 messages (no more parallel reception). I find it a pity not to use the HW capabilities, but we can do it if you like.
I don't understand the impact of adding an a value in the enum type on other platforms. They all have a check on the IRQ value, and don't handle it when they don't recognize the irq id.
Let me know your decision, I'll implement it.
Cheers

Imagine how this would be used by the application? Yo ushould have a look at Sam's comment : #1520 (comment) . How an app register callbacks?

Can contains 2 fifos. Both generates its own interrupt. IRQ_RX occurs when a message has arrived in FIFO-0 , FIFO-0 is full or overrun. IRQ_RX1 occurs when a message has arrived in FIFO-1 , FIFO-1 is full or overrun.

0xc0170 · 2016-02-10T08:25:51Z

libraries/mbed/targets/hal/TARGET_STM/TARGET_STM32F4/can_api.c

+    {0xF, 0x7},      // 24, 67%
+};
+
+static unsigned int can_speed(unsigned int pclk, unsigned int cclk, unsigned char psjw) 


Was this copied from other CAN implementation ? I recall I saw it there, if yes, add a comment where it was taken from. There's quite magic in this function, would be worth documenting.

I'll document the code. This table contains values for the bit timing. We have observed that most customers are using a sampling % of around 75%.

Yes, please do

0xc0170 · 2016-02-10T08:26:39Z

cc @sg- - please have a look

sg- · 2016-02-12T00:36:23Z

I don't think this will work. The user code passes these: https://github.com/mbedmicro/mbed/blob/master/libraries/mbed/api/CAN.h#L194 but they will never pass enum value 10 to enable that irq.

0xc0170 · 2016-02-20T08:32:11Z

Bump, any updates?

adustm · 2016-02-22T10:10:10Z

Hi,
I am removing RX1 interrupt. I'll update the PR today.
Cheers

adustm · 2016-02-22T14:59:10Z

Hello,
This PR is ready from my point of view. Please check the IRQ_RX1 removal and let me know the status.
Kind regards

[STM B96B_F446VE] Add CAN feature

…changes from c9bf20f..43c7ec2 43c7ec2 Merge branch 'release_internal' into release_external ed76459 Merge pull request ARMmbed#1558 from ARMmbed/IOTTHD-2195 8d3bcb7 Add new function to unit tests 56f66a4 Review correction 8b7d018 Move indirect queue size public API to net_interface d877c9e Review corrections c25e476 Remove Eclipse project files for external release d51f442 Merge branch 'release_internal' into release_external 135c48d Increase Thread SED buffer size for big packets 70931a7 Fix indirect queue packet ordering 10e51a4 API for changing Thread SED parent buffer size 6122d24 dereference null value issue fixed. (ARMmbed#1557) d1378dc Clear IPv6 neighbor cache in partition change (ARMmbed#1554) 7610e91 Child neighbor entry updates (ARMmbed#1550) c727295 cleared neighbours with child address that are not ours (ARMmbed#1549) 80b4d72 Thread partition merge mode TLV change (ARMmbed#1546) edd7599 RLOC was updated before clearing child info (ARMmbed#1547) a666056 router short address set to 0xfffe for non routers (ARMmbed#1543) 759ab05 delete route set and link set entries for a router ID (ARMmbed#1540) 23a1265 REED advertisement handling (Thread spec 5.16.3): (ARMmbed#1535) 0a32cb4 added active and pending timestamps to child update response (ARMmbed#1533) d0eec80 Fix error case memory leak (ARMmbed#1537) da9860f Pending set after link sync (ARMmbed#1526) ffa1569 Thread router network data update after link sync (ARMmbed#1530) 3b46d8d Fix defects found by coverity (ARMmbed#1529) 3a57101 Fix compiler warnings and update traces (ARMmbed#1523) c288227 Add extension check for partition weight drop in parent selection (ARMmbed#1521) d8dea28 network data cleared after router forms new partition (ARMmbed#1525) 44a85e5 removed router flagging for thread_management_server file (ARMmbed#1524) 1cbced9 Merge pull request ARMmbed#1520 from ARMmbed/IOTTHD-2105_2 3d07365 Review corrections to network data clearing 22a0375 Clear network data from lost children ffd8517 added a new thread management function (ARMmbed#1519) 80af9cb Thread BR network data clearing (ARMmbed#1518) 5a6f6b5 thread nvm valgrind uninitialized data fix (ARMmbed#1517) d5e2198 Add API for partition weighting set (ARMmbed#1513) 8811d6f multicast forwarding scope changed and address registration updated. (ARMmbed#1516) c277384 printf to tr_info (ARMmbed#1515) bb21264 Thread combined nvm test (ARMmbed#1507) 76f7725 Primary BBR fixes from interop (ARMmbed#1512) 12ed5ab FHSS unit test: fixed fhss mac interface test (cherry picked from commit 805eb42e4416b00cc018dc32dceb353d0b6c8bb6) dd21ea9 Remvoed unnecessary trace print's. cb6e78b FHSS unit test: fixed fhss beacon tasklet test (cherry picked from commit abe6d671b058f4f069741eab24d51e4d62d550b0) 237b3d4 Fhss info print (ARMmbed#1486) 0f39a47 FHSS: Do not update synch monitor right after superframe change (cherry picked from commit 99d50ad9d7f8dad80f10c2a4303f4e75ab31a3c2) c9a098f Fixed Timeoout force which actually never generate timeout. 957c7fb Pana server and client update: ae230e5 FHSS: Update Beacon synch info in critical state 84bd8a4 FHSS: Synchronization must be done in critical state fb1b163 Pan coordinator blacklist update 39fe6ba Added missing HAVE_RPL compiler flag 16a1bc5 MLE bootsrap and message timeout update eeb2d39 enable BBR to support multicast registration in non commercial networks (ARMmbed#1509) 4ea2bf8 uri modified. (ARMmbed#1510) f443853 timeout corrected for neighbour entry (ARMmbed#1508) ea93c1f Thread dev conf taken use (ARMmbed#1503) 5d5b239 bug fix in bbr start (ARMmbed#1505) 8dbd521 commented a trace. (ARMmbed#1504) 145dbdf device conf copy fix (ARMmbed#1502) f60268f eid&random mac moved to device conf struct (ARMmbed#1497) df18635 Let MAC choose address when mesh forwarding 42f916b fixed BBR stop to remove network data and routing information (ARMmbed#1500) e058c2a pbbr changes (ARMmbed#1499) 1ece307 Merge pull request ARMmbed#1485 from ARMmbed/merge_release_back dda8164 thread address handling updated. (ARMmbed#1496) 1dc21a1 thread extension fixes. (ARMmbed#1495) 543fe98 Merge branch 'release_internal' bade70e Dua req changes (ARMmbed#1494) 1979df8 added status to MLR response and implemeted BMLR.ntf multicast. (ARMmbed#1492) 1807c01 mle class initialisation (ARMmbed#1488) d809831 Merge pull request ARMmbed#1479 from ARMmbed/merge_release_to_master bce812d Update license to Thread test file (ARMmbed#1483) aaa4b1f Revert eclipse file removal git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/sal-stack-nanostack git-subtree-split: 43c7ec2

adustm added 3 commits January 28, 2016 16:31

[B96B_F446VE] Add CAN Feature

1325d8c

[B96B_F446VE] Add Can test files + bug fix in can_api.c

6ff8955

[B96B_F446VE] Add the target for can test

a58480e

adustm mentioned this pull request Jan 29, 2016

B96B_F446VE + NUCLEO_F446RE CAN API #1477

Closed

0xc0170 reviewed Jan 30, 2016
View reviewed changes

[B96B_F446VE] add IRQ_RX1 interrupt

c11325e

Can contains 2 fifos. Both generates its own interrupt. IRQ_RX occurs when a message has arrived in FIFO-0 , FIFO-0 is full or overrun. IRQ_RX1 occurs when a message has arrived in FIFO-1 , FIFO-1 is full or overrun.

0xc0170 reviewed Feb 10, 2016
View reviewed changes

0xc0170 added the needs: review label Feb 10, 2016

0xc0170 added the needs: work label Feb 20, 2016

adustm added 4 commits February 22, 2016 15:24

[B96B_F446VE] remove unused IRQ_RX1 interrupt

3df28ea

[B96B_F446VE] Add more details about the timing_pts table

4a4cb7f

[B96B_F446VE] Remove unused IRQ_RX1 interrupt (init / irq_set / ...)

8e8af8f

[B96B_F446VE] remove spaces (typo)

20c34f4

0xc0170 added a commit that referenced this pull request Feb 26, 2016

Merge pull request #1520 from adustm/b_b96b_can

bd0417c

[STM B96B_F446VE] Add CAN feature

0xc0170 merged commit bd0417c into ARMmbed:master Feb 26, 2016

0xc0170 removed needs: review needs: work labels Feb 26, 2016

adustm deleted the b_b96b_can branch February 29, 2016 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[STM B96B_F446VE] Add CAN feature #1520

[STM B96B_F446VE] Add CAN feature #1520

Uh oh!

adustm commented Jan 29, 2016

Uh oh!

0xc0170 Jan 30, 2016

Uh oh!

adustm Feb 1, 2016

Uh oh!

0xc0170 Feb 1, 2016

Uh oh!

adustm Feb 1, 2016

Uh oh!

adustm Feb 12, 2016

Uh oh!

0xc0170 Feb 16, 2016

Uh oh!

0xc0170 Feb 10, 2016

Uh oh!

adustm Feb 12, 2016

Uh oh!

0xc0170 Feb 20, 2016

Uh oh!

0xc0170 commented Feb 10, 2016

Uh oh!

sg- commented Feb 12, 2016

Uh oh!

0xc0170 commented Feb 20, 2016

Uh oh!

adustm commented Feb 22, 2016

Uh oh!

adustm commented Feb 22, 2016

Uh oh!

Uh oh!

[STM B96B_F446VE] Add CAN feature #1520

[STM B96B_F446VE] Add CAN feature #1520

Uh oh!

Conversation

adustm commented Jan 29, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 10, 2016

Uh oh!

sg- commented Feb 12, 2016

Uh oh!

0xc0170 commented Feb 20, 2016

Uh oh!

adustm commented Feb 22, 2016

Uh oh!

adustm commented Feb 22, 2016

Uh oh!

Uh oh!