-
Notifications
You must be signed in to change notification settings - Fork 3k
Progen data refactor #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progen data refactor #1563
Conversation
The new format progen = dict() should allow to add more data used by progen. The target can add tool flags to be overwritten by the default mbed template, or even inject own template. This might be required for some targets. Therefore we shall allow thiss.
@TomoYamanaka just a heads up, with this changeset, exporting to IAR for rz_a1h should be functional, however I noticed there's fpu settings mismatch in the project (=warning), I would like to fix this. If you find time to test, the latest progen def (v0.2.7) includes your mcu. |
Each target can specify own template. This is however not recommended for general use. Each target should be supported by progendef, and well definied. However, as tools are quickly changing, some targets add extra information which might not be supported, this template expansion allows a target to temporary override default mbed tool template. In this commit, we add RZ_A1H iar template. I experienced with never tools some breakage in the templates, this might come handy, but repeat, please consider using the default template, and contribute to progen or progendef which should contain fixes or support for newer targets/tools.
26ff9f6
to
a64119f
Compare
@TomoYamanaka I updated this PR, your target should build with IAR. Can you please test this PR ? My above comment is now fixed ,no warnings/errors, using IAR 7.10. I just updated to 7.40 , will test tomorrow. @bridadan Please test this, review. |
@@ -1633,6 +1760,13 @@ def __init__(self): | |||
self.supported_toolchains = ["ARM", "GCC_ARM", "IAR"] | |||
self.supported_form_factors = ["ARDUINO"] | |||
self.default_toolchain = "ARM" | |||
self.progen = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dict needs documentation ! I think we should create readme in exporters, where this is documented what progen expects. As we can see , this can be expanded by flags for various tools. or in the future other data which might be required - as stated in the commit message
Built and ran MBED_10 test on K64F and RZ_A1H, both look good! |
This is not required for progen functionality, but better to have the template clean from files and defines.
The new format progen = dict() should allow to add more data used by progen.
The target can add tool flags to be overwritten by the default mbed template, or
even inject own template. This might be required for some targets. Therefore we
shall allow thiss.
I added gr-peach target . The new version of progendef will be released soon, then we can merge this. This target requires special fpu settings in IAR as I noticed, which is currently not set for this mcu, something I need to address in progendef.
@bridadan