Remove IAR from all NRF51822-based targets #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test does not run mean ? Please provide more details. We should create a tracking issue for this, I consider this to be revert this until we fix it. |
|
All tests fail to compile meaning the IAR support doesn't work at all. |
|
The tests actually compile just fine (Sorry Sam, must have misspoke yesterday). They don't run though (no serial output from the tests) |
|
@bridadan Please create a tracking issue for this, shall be fixed. Once created, reference this PR there, and we can merge this |
0xc0170
added a commit
that referenced
this pull request
Feb 28, 2016
Remove IAR from all NRF51822-based targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes IAR support from all NRF51822-based targets.
Currently tests do not run on NRF51822 targets when compiled with IAR. The current definition of the NRF51_DK target specifically removes IAR support in its definition. This PR unifies this removal across all of these targets.