Exporter - progen include dirs fix #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbed scripts copy files, therefore file paths are not valid at the moment of ahe project generation. Therefore checks like os.path.isdir or isfile fail. If include is set to TARGET/FOLDER, this would be treated as a file, and added to the project workspace. This commit fixes it, it adds dirs only to include_paths, as it should.
0xc0170
added a commit
that referenced
this pull request
Mar 3, 2016
Exporter - progen include dirs fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbed scripts copy files, therefore file paths are not valid at the moment of ahe project generation.
Therefore checks like os.path.isdir or isfile fail. If include is set to TARGET/FOLDER, this would be
treated as a file, and added to the project workspace. This commit fixes it, it adds dirs only to
include_paths, as it should.
If we export to IAR, there are non valid files currently, folders as a result of inc_dirs added to includes. It does not affect build, thus cosmetic error in this case.
I'll have a look at this, how progen or mbed scripts can handle this better. One possibility would be to enable include_paths to be set in progen data, as sometimes (in this case)
includes != include_paths@bridadan