Adding missing dependencies

[bridadan]

Adds a few missing dependencies to requirements.txt and setup.py

[0xc0170]

Why there is this duplication (req.txt vs setup.py) ?

[bridadan]

requirements.txt allows you to install the dependencies without actually installing the compiled python scripts to your path. It makes development and CI testing easier.

[0xc0170]

requirements.txt allows you to install the dependencies without actually installing the compiled python scripts to your path. It makes development and CI testing easier.

Sorry, I meant why req is not injected into setup.py to avoid duplication. For instance:

# txt stays, but setup.py will include this
requirements = [str(requirement.req) for requirement in parse_requirements('requirements.txt', session=pip.download.PipSession())]

install_requires = requirements

[bridadan]

Oh I do like that. Though that does add a dependency on pip though right? Since parse_requirements is part of the pip package.

Seems like a sensible dependency though. Just wondering if that could be an issue on older systems.

[0xc0170]

We can have a look at this. I'll merge this as it is for now.