Skip to content

Added support for SAMG55 #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Apr 5, 2016
Merged

Added support for SAMG55 #1627

merged 48 commits into from
Apr 5, 2016

Conversation

Parthasarathy
Copy link
Contributor

No description provided.

akhilpanayamparambil and others added 30 commits March 24, 2016 17:19
* added template file for samd55j19
* added support for some test for gpio.
* added test support for serial flow control
* update in lp ticker apis.
* usticker file updated with latest source.
* updated gpio irq apis and added test for the same.
* updated files for KnR Coding Statndard.
* updated serial and usticker apis.
@Parthasarathy
Copy link
Contributor Author

Review comments are available at : #1550

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2016

I'll pull this sources soon to review, Serial async test - there was one failure, is this fixed?

@Parthasarathy
Copy link
Contributor Author

@0xc0170

The following Serial async test failure was due to a limitation, the test expects to abort transfer once character match happens, Since we are using DMA to transfer by the time character match is identified the transfer is completed so the test fails.

TEST(Serial_Asynchronous, char_matching_success)

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2016

I see. That is expected. the char match is intended in this cases to fallback to IRQ in most cases.

@akhilpanayamparambil
Copy link
Contributor

Hi @0xc0170
Please let me know if we have any update on this PL.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2016

I pulled this locally last Friday, have to go through it as github fails with this big PR. My goal is to get this resolved within Tuesday

cc @bridadan New targets

@akhilpanayamparambil
Copy link
Contributor

Thanks for the update @0xc0170 👍

@0xc0170 0xc0170 merged commit dd3c5f7 into ARMmbed:master Apr 5, 2016
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2016

@akhilpanayamparambil @Parthasarathy The merge button provided an option squash for this one 😭 (there are 2 ways to merge now on github, I just clicked on merge button, overlooked it was the squash one). We could revert that commit, and send the new patch with all this history. Let me know

@kgoveas
Copy link

kgoveas commented May 23, 2016

Hi @Parthasarathy ,

There seems to be a bug in the implementation of the SPI.

In spi_driver.c, line 318,
void spi_set_clock_phase(Spi *p_spi, uint32_t ul_pcs_ch, uint32_t ul_phase) { if (ul_phase) { p_spi->SPI_CSR[ul_pcs_ch] |= SPI_CSR_NCPHA; } else { p_spi->SPI_CSR[ul_pcs_ch] &= (~SPI_CSR_NCPHA); } }
For phase = 0, phase = 1 is applied.

It works as expected if the following line is amended to,
if (!ul_phase)

@Parthasarathy
Copy link
Contributor Author

Thanks @kgoveas, I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants