Add lifetime management to threads #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows threads to started separately from when they are declared, avoiding the need to dynamically allocate threads at runtime. - Allows multiple threads to join without forceful termination. Allowing threads to synchronize on cleanup.
| @@ -32,34 +32,82 @@ extern "C" P_TCB rt_tid2ptcb(osThreadId thread_id); | |||
|
|
|||
| namespace rtos { | |||
|
|
|||
| Thread::Thread(osPriority priority, | |||
| uint32_t stack_size, unsigned char *stack_pointer): | |||
| _tid(NULL), _dynamic_stack(stack_pointer == NULL) { | |||
There was a problem hiding this comment.
This needs to be _tid((osThreadId)NULL), ... instead. After that travis will pass.
|
The null issue should be fixed now. I also added you guys as collaborators on my fork, so feel free to squash the commits if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Proposed solution:
Thread::start in other languages: c++, c, java, python
Thread::join in other languages: c++, c, java, python
cc @niklas-arm, @sg-, @c1728p9, @0xc0170
mv #79