Rename "features" to "device_has" in targets.json #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"features" will make more sense in the context of the feature support that we'll introduce later (related to #1878). Plus, "device_has" is arguably a better description of the actual content of this key.
|
Why not "provides"? "device_has" sounds strange. |
|
Cc @sg-. I guess "provides" makes sense too. Your call. |
|
I don't like provides as a label and using DEVICE_ in the -D. Its confusing. device_has and -DDEVICE is a bit nicer IMO |
|
it was originally provides. :) |
|
LGTM |
ohagendorf
added a commit
to ohagendorf/mbed-os
that referenced
this pull request
Jun 9, 2016
PR ARMmbed#1881 renamed option in targets.json - this commit is doing the same with the new target
ohagendorf
added a commit
to ohagendorf/mbed-os
that referenced
this pull request
Jul 1, 2016
PR ARMmbed#1881 renamed option in targets.json - this commit is doing the same with the new target
ohagendorf
added a commit
to ohagendorf/mbed-os
that referenced
this pull request
Jul 1, 2016
PR ARMmbed#1881 renamed option in targets.json - this commit is doing the same with the new target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"features" will make more sense in the context of the feature support
that we'll introduce later (related to #1878). Plus, "device_has" is
arguably a better description of the actual content of this key.