Add virtual destructor to classes #1910
Merged
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1728p9
force-pushed
the
add_virtual_destructors
branch
from
a526872 to
614d3fc
Compare
|
@mbed-bot: TEST HOST_OSES=windows |
| @@ -122,6 +122,10 @@ class AnalogOut { | |||
| } | |||
| #endif | |||
|
|
|||
| virtual ~AnalogOut() { | |||
| // Do nothing | |||
There was a problem hiding this comment.
this comment do nothing is redundant in all of them?
There was a problem hiding this comment.
Just wanted to indicate that the code was not forgotten accidentally. Want me to remove it?
|
[Build 469] |
Add a virtual destructor to classes which have a virtual lock and unlock. Remove the virtual qualifier from functions in InterruptManager since this class cannot be extended.
c1728p9
force-pushed
the
add_virtual_destructors
branch
from
614d3fc to
58d15f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a virtual destructor to classes which have a virtual lock and
unlock. Remove the virtual qualifier from functions in
InterruptManager since this class cannot be extended.