-
Notifications
You must be signed in to change notification settings - Fork 3k
Fixing test builds for devices with softdevices. #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What about static libraries, like there are bootloaders as static libs or just another software that can't be open sourced , but has to be included in the build? |
Can we copy hex files by default and drop the parameter? This is for library builds after all and do not affect application build. |
I was hesitant to do this because I wasn't sure if the |
@bridadan see comments above. Dont modify build lib. its legacy |
9dbb13c
to
6caf158
Compare
@mbed-bot: TEST HOST_OSES=windows |
[Build 482] |
The build bot didn't try and build the tests locally, but I just tried. I'm getting the following linker error when building for the NRF51822 with GCC_ARM for many of the tests:
@c1728p9 Do you know if this is because the tests are too big to fit in the ROM? I'm not familiar with this error cc @pan- |
@bridadan To makes mbed BLE works with the RTOS work, the main stack size has been changed. Let me have a look, maybe it is possible to gain memory from elsewhere. |
@@ -149,7 +149,8 @@ | |||
name="mbed-build", | |||
macros=options.macros, | |||
verbose=options.verbose, | |||
archive=False) | |||
archive=False, | |||
copy_hex_files=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bridadan please remove the copy_hex_files=true. I think this was a leftover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch! I've updated the commit.
Previously, .hex files were not copied when building source as a library. This prevents builds that pre compile source as a library and then includes the build directory as the only source (because there is no softdevice present). This PR copies hex files when compiling source as a library.
6caf158
to
5a46ac7
Compare
Thanks!! 👍 |
@screamerbg Do we need to resolve this? Or maybe @pan- can help them rebase/update their fork? |
@bridadan You don't need do it, I will just |
Previously, .hex files were not copied when building source as a library.
This prevents builds that pre-compile source as a library and then includes the build directory as the only source (because there is no softdevice present). This PR adds an option to copy hex files when compiling source as a library. This is currently being used when compiling tests within
test.py
Please review @0xc0170 and @screamerbg
FYI @pan-