In targets.json, add the "IPV4" setting for RZ_A1H #2018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an update to RTX kernel for Cortex-A version to allow c++ libc array init to be called after kernel start. Ref: #1730
We added "IPV4" of Compile Macro in "targets.json" file. We failed in the reletion test of IPV4 because "IPV4" was not entered into our Build Target setting.
| low_level_init_needed_local = __low_level_init(); | ||
| if (low_level_init_needed_local) { | ||
| __iar_data_init3(); | ||
| mbed_sdk_init(); |
There was a problem hiding this comment.
please look at https://github.com/mbedmicro/mbed/pull/1998/files, mbed_main() should be called here?
There was a problem hiding this comment.
Should be done in pre_main function
|
@TomoYamanaka can you rebase this? Looks like there is a duplicate commit that was merged already. |
|
Thank you for your comments. I will rebase this PR. |
|
In order to rebase, I close this PR. |
sg-
added a commit
that referenced
this pull request
Jun 30, 2016
In targets.json, add the "IPV4" setting for RZ_A1H(Rebase #2018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
We added "IPV4" of Compile Macro in "targets.json" file.
We failed in the reletion test of IPV4 because "IPV4" was not entered into our Build Target setting.
Regards,
Yamanaka