Updated requirements.txt to match setup.py. #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from requirements.txt in the future.
|
LGTM 2 things that can be fixed separately:
@bridadan I recall you knew why there was this duplication, we discussed this earlier. Shall we fix this as a separate PR. @PrzemekWirkus versions of mbed-ls and greentea? I would assume using more strict versioning, for greentea >=0.2.x, <0.3.0 , similar for mbedls. |
|
@0xc0170 I don't believe there's a good reason why there's duplication. Seems like we'd want to fix this in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider setup.py reading from requirements.txt in the future.