Progen build tests #2080

sarahmarshy · 2016-06-30T16:34:10Z

I have separated some of the exporter logic in project.py to project_api.py. I did this because I wanted to use some of that functionality in the new build_test script. build_test allows testing of ide builds (currently supports iar, uvision, and uv5) using progen.

build_test examples:

builds blinky for iar and k64f

python build_test.py -i iar -t MBED_BLINKY -m K64F

build blinky and Hello World test for all targets on all (supported) ides

python build_test.py -t MBED_BLINKY MBED_10

builds all tests (current default is just blinky but you can specify more with -t) for all progen targets on all ides

python build_test.py

0xc0170 · 2016-06-30T17:24:48Z

To have tests it's great, shall we add it to the travis , to always run exporting at least, or what do you think?

sg- · 2016-06-30T17:26:17Z

@0xc0170 YES!

sarahmarshy · 2016-06-30T19:53:33Z

@0xc0170 @sg - this test doesn't have the option for just exporting. It always tries to run progen's build. I could add a flag for just exporting?

sg- · 2016-06-30T20:00:32Z

This should just build using the ide builder and store the results. Its an entry point for CI only, not usability.

bridadan · 2016-06-30T21:05:14Z

Awesome!!

We've started to put some tools tests inside the test directory here: https://github.com/mbedmicro/mbed/tree/master/tools/test

Currently only the config system tests lives there, could this live there too? Maybe tools/test/exporters or something?

0xc0170 · 2016-06-30T21:26:57Z

@0xc0170 @sg - this test doesn't have the option for just exporting. It always tries to run progen's build. I could add a flag for just exporting?

It's good as it is, but I would consider only exporting. Not all tools provide builders, export should be verified, that at least it does not end up in the traceback. We just need CI command to trigger python script tests that require our CI (in this case tools like IAR, uvision and others to be installed). @bridadan we need your help

Currently only the config system tests lives there, could this live there too? Maybe tools/test/exporters or something?

Makes sense to have all tests under tools/test

0xc0170 · 2016-07-01T07:41:35Z

requirements.txt

@@ -3,7 +3,7 @@ PySerial>=2.7
 PrettyTable>=0.7.2
 Jinja2>=2.7.3
 IntelHex>=1.3
-project-generator>=0.9.3,<0.10.0
+project-generator>=0.9.6,<0.10.0


I would propose the latest v0.9.7 as 0.9.6 contained a bug with the iar template.

0xc0170 · 2016-07-01T08:11:39Z

I fetched this patch, working for me - tested mbed blinky for uvision. I would suggest to print a message that something is happening, for me the blinky after it copies the files, took like a minute and I was not sure what is happening. We can expect that for bigger applications this could take >2minutes. What do you think? The status message - program exported, building it . I tried to use -v verbose mode, but not recognized, might be a feature request.

I left there cosmetic changes, the general looks fine to me. Please consider tools/test location for the build_test script (probably under export folder).

sarahmarshy · 2016-07-01T14:37:04Z

@0xc0170 I can add a status message. I think rather than being a verbose feature, it should be default? Like you said, would generally be confusing. Can add verbose mode later for other features. I was thinking verbose mode might set progen's logging level to debug.

theotherjimmy · 2016-07-01T14:40:16Z

@sarahmarshy that sounds reasonable. If you would like to have 'verbose mode' as default, the common style of disabling messages via the command line is a --silent switch.

sarahmarshy · 2016-07-01T19:26:41Z

tools/export/__init__.py

@@ -93,12 +96,13 @@ def export(project_path, project_name, ide, target, destination='/tmp/',
                    use_progen = True
            except AttributeError:
                pass
+
+            if target not in Exporter.TARGETS or ide.upper() not in TARGET_MAP[target].supported_toolchains:
+                supported = False


@0xc0170
What do you think about this? Not sure why progen checks were different. Maybe we should think about getting rid of the hard coded targets in gcc, etc?

I think it's useful to have those targets as a list (scripts used it to enable exporting in the online IDE) ,but not hard coded (progen provides API to check if target is supported), the way we do for uvision. Does that answer your question?

0xc0170 · 2016-07-04T10:52:43Z

LGTM (just that small cosmetic prefix progen)

0xc0170 · 2016-07-05T14:57:30Z

Ready for integration?

sarahmarshy · 2016-07-05T15:01:56Z

@0xc0170 Going to add building from exported yaml file (creating a new Project object as opposed to using the same instantiation used for export), so I will add that. @sg- separate PR?

sg- · 2016-07-06T06:10:50Z

separate PR sounds good.

sarahmarshy · 2016-07-06T14:38:50Z

@0xc0170 then I think it is ready. This branch builds with the yaml: https://github.com/sarahmarshy/mbed/commits/build_with_yaml

0xc0170 · 2016-07-11T10:18:28Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,LPC1768

0xc0170 · 2016-07-11T10:18:51Z

@sarahmarshy Please rebase

mbed-bot · 2016-07-11T10:51:59Z

[Build 608]
FAILURE: Something went wrong when building and testing.

sarahmarshy · 2016-07-11T14:36:58Z

@0xc0170 it also needs that PR from progen merged. The one for build logs with IAR

0xc0170 · 2016-07-11T14:47:34Z

it also needs that PR from progen merged. The one for build logs with IAR

Please specify any dependencies, if this requires another repo change, will require addition to the requirements as well

…pported toolchains per target.

bridadan · 2016-07-14T17:17:48Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,LPC1768

mbed-bot · 2016-07-14T18:09:15Z

[Build 627]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

bridadan · 2016-07-14T19:04:34Z

The failing K64F tests are definitely not being caused by the changes here. I think the timing at which the test runner script was reading the serial output was affected by a long-running exporter test running on the same machine. I'm surprised that it was affected so much though.

Any way, test results look ok!

0xc0170 · 2016-07-15T07:13:29Z

tools/export/exporters.py

-    def progen_gen_file(self, tool_name, project_data):
-        """ Generate project using ProGen Project API """
+    def progen_gen_file(self, tool_name, project_data, progen_build=False):
+        """" Generate project using ProGen Project API """


why was " added?

0xc0170 · 2016-07-15T07:28:46Z

@screamerbg review

sarahmarshy · 2016-07-15T16:27:54Z

@0xc0170 I am closing this. I needed to rebase on top of the changes that have occurred in projects.py since this request was created. Please move conversation to this pr.

0xc0170 added the needs: review label Jun 30, 2016

0xc0170 reviewed Jul 1, 2016
View reviewed changes

sarahmarshy reviewed Jul 1, 2016
View reviewed changes

0xc0170 removed the needs: review label Jul 4, 2016

sarahmarshy force-pushed the progen_build_tests branch from d0be999 to 850bbb0 Compare July 6, 2016 14:36

0xc0170 added the needs: CI label Jul 11, 2016

sarahmarshy added 11 commits July 14, 2016 11:56

Progen build tests and project_api

c6aa902

Comments

afa4b33

kwargs check in iar and comments

0874ccc

Changed default mcus for progen build test

e6ab2dd

Updated requirements.txt for latest progen release

23a512d

Test moved to tools/test/export. Kwaargs eliminated. Build message

d9d75bf

Creates directory of ide project files and option to clean

2722854

Script exits with the number of failures

ba305c2

Added calls to targets.json to check supported toolchains. Skips unsu…

e91cb1c

…pported toolchains per target.

Bug fix: checking IDE toolchain and not ide in targets.json

3977783

Pgen variable changed to progen

82d22be

sarahmarshy force-pushed the progen_build_tests branch from 850bbb0 to 82d22be Compare July 14, 2016 17:01

0xc0170 reviewed Jul 15, 2016
View reviewed changes

0xc0170 removed the needs: CI label Jul 15, 2016

sarahmarshy closed this Jul 15, 2016

sarahmarshy mentioned this pull request Jul 15, 2016

IDE build tests with progen #2179

Merged

Progen build tests #2080

Progen build tests #2080

Uh oh!

Conversation

sarahmarshy commented Jun 30, 2016

Uh oh!

0xc0170 commented Jun 30, 2016

Uh oh!

sg- commented Jun 30, 2016

Uh oh!

sarahmarshy commented Jun 30, 2016

Uh oh!

sg- commented Jun 30, 2016

Uh oh!

bridadan commented Jun 30, 2016

Uh oh!

0xc0170 commented Jun 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 Jul 1, 2016

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarahmarshy commented Jul 1, 2016

Uh oh!

theotherjimmy commented Jul 1, 2016

Uh oh!

sarahmarshy Jul 1, 2016

Choose a reason for hiding this comment

Uh oh!

0xc0170 Jul 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 4, 2016

Uh oh!

0xc0170 commented Jul 5, 2016

Uh oh!

sarahmarshy commented Jul 5, 2016

Uh oh!

sg- commented Jul 6, 2016

Uh oh!

sarahmarshy commented Jul 6, 2016

Uh oh!

0xc0170 commented Jul 11, 2016

Uh oh!

0xc0170 commented Jul 11, 2016

Uh oh!

mbed-bot commented Jul 11, 2016

Uh oh!

sarahmarshy commented Jul 11, 2016

Uh oh!

0xc0170 commented Jul 11, 2016

Uh oh!

bridadan commented Jul 14, 2016

Uh oh!

mbed-bot commented Jul 14, 2016

Uh oh!

bridadan commented Jul 14, 2016

Uh oh!

0xc0170 Jul 15, 2016

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 15, 2016

Uh oh!

sarahmarshy commented Jul 15, 2016

Uh oh!

Uh oh!

0xc0170 commented Jun 30, 2016 •

edited

Loading

0xc0170 commented Jul 1, 2016 •

edited

Loading

0xc0170 Jul 4, 2016 •

edited

Loading