Skip to content

Fix#2089 #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2016
Merged

Fix#2089 #2090

merged 2 commits into from
Jul 5, 2016

Conversation

jamike
Copy link
Contributor

@jamike jamike commented Jul 3, 2016

1st commit fixes a built issue for STM32F3 on IAR.
With this 1st commit , IAR built is passed, but RTOS_4 (IAR) is failed on NUCLEO_F303K8 due to issue #2089.
The 2nd commit fixes issue #2089, and RTOS_4 is passed on IAR.

jamike and others added 2 commits July 3, 2016 23:46
i.e test RTOS_4 on NUCLEO_F303K8 with IAR fails.
(rt_stk_check detects that main_stack Magic is corrupted)
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=IAR
TARGETS=ALL

@mbed-bot
Copy link

mbed-bot commented Jul 4, 2016

[Build 575]
FAILURE: Something went wrong when building and testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2016

To the second commit: Was the failure only for one target ? I would assume it should have been shown by more targets.

The fix looks fine to me, to the current implementation of IAR c lib.

Tests results are good

cc @c1728p9

@jamike
Copy link
Contributor Author

jamike commented Jul 4, 2016

As, I focused on STM32F3, the error is observed on other board from STM32F3 and other tests.
But I don't have the test reports of the failing boards/tests, all the tests are now passed on my side for STM32F3 family.

@jamike jamike mentioned this pull request Jul 4, 2016
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2016

For future, please split unrelated changes to separate patches (1. fix iar compilation 2. RTX - IAR main stack size fix)

@0xc0170 0xc0170 merged commit fe3b80a into ARMmbed:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants