Fix pwmout period #2103
Merged
Fix pwmout period #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
July 5, 2016 10:53
The new period needs to be saved before the duty cycle is updated as the period is used in pwmout_write function. Also presclaer shall better be initiliazed properly.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
Some of the objects in object.h are the same for all targets. Create a place where to define those common definitions, and start using it for pwm object.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
As first reported on STM32F3 family in ARMmbed#1682, we need to cope with periods in the seconds range as well. This is fixed here in the same way as was done for STM32F3 by using the pre-scaler.
|
@0xc0170 any blocking for merging or do you need any specific extra info ? |
|
we'll run CI, and review the code |
|
@mbed-bot: TEST HOST_OSES=ALL |
|
[Build 619] |
|
Tests results are fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the below existing STM32F3 fix to other STM32 families.
[STM32F3] Increase the supported period range (#1682)
The fix allows to support and use wider pwmout period range.
While doing the change, I introduce a common header file to avoid duplicate definition of the same structures. This same header file (common_ojects.h) can be later use to bring in even more common definitions.