-
Notifications
You must be signed in to change notification settings - Fork 3k
[Exporter-gcc_arm] do builds from project directory when --source is specified #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrects a python barf when something in features is None - Corrects makefile to prevent barf when using make -f
I tried a few ways and still not seeing success
|
My feedback:
Both are executed within the exporter project ( Using windows, linux test is required as well |
I was able to reproduce Sam's report, using cygwin under windows:
@theotherjimmy Please test on windows/unix :-) |
There are two shell-like things that we care about bash: does environment varible expansion with $ batch: does environment varible expansion by surrounding something with % so to detect batch, try to expand a variable on the shell with $. If you get a $ back, you are in batch!
'cause windows silly path separator is the same as the escape character
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix a few bugs along the way: