Skip to content

[Exporter-gcc_arm] do builds from project directory when --source is specified #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 6, 2016

Conversation

theotherjimmy
Copy link
Contributor

Also, fix a few bugs along the way:

  • python barf when something in features is None

 - Corrects a python barf when something in features is None
 - Corrects makefile to prevent barf when using make -f
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2016

cc @sg- @bridadan @bogdanm please test any example you have, using gcc_arm and report

@sg-
Copy link
Contributor

sg- commented Jul 6, 2016

I tried a few ways and still not seeing success

(workspace) C:\Development\tmp\mbed-os-example-blinky>mbed export -i gcc_arm -m K64F -n blinky

Successful exports:
  * K64F::gcc_arm       .\projectfiles\gcc_arm_K64F\blinky

(workspace) C:\Development\tmp\mbed-os-example-blinky>make .\projectfiles\gcc_arm_K64F\Makefile
make: Nothing to be done for `.\projectfiles\gcc_arm_K64F\Makefile'.

(workspace) C:\Development\tmp\mbed-os-example-blinky>make .\projectfiles\gcc_arm_K64F\Makefile all
make: Nothing to be done for `.\projectfiles\gcc_arm_K64F\Makefile'.
make: *** No rule to make target `all'.  Stop.

(workspace) C:\Development\tmp\mbed-os-example-blinky>cd projectfiles\gcc_arm_K64F

(workspace) C:\Development\tmp\mbed-os-example-blinky\projectfiles\gcc_arm_K64F>make
/usr/bin/bash: -c: line 1: syntax error: unexpected end of file
make: *** [all] Error 1

(workspace) C:\Development\tmp\mbed-os-example-blinky\projectfiles\gcc_arm_K64F>make all
/usr/bin/bash: -c: line 1: syntax error: unexpected end of file
make: *** [all] Error 1

(workspace) C:\Development\tmp\mbed-os-example-blinky\projectfiles\gcc_arm_K64F>

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2016

My feedback:

  • project.py - makefile working for MBED_10
  • mbed export - working for me as well

Both are executed within the exporter project (cd to the project, execute make)

Using windows, linux test is required as well

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2016

I was able to reproduce Sam's report, using cygwin under windows:

/bin/sh: -c: line 1: syntax error: unexpected end of file
Makefile:21: recipe for target 'all' failed
make: *** [all] Error 1

@theotherjimmy Please test on windows/unix :-)

There are two shell-like things that we care about
 bash: does environment varible expansion with $
 batch: does environment varible expansion by surrounding something with %

so to detect batch, try to expand a variable on the shell with $.
If you get a $ back, you are in batch!
'cause windows silly path separator is the same as the escape character
@sg-
Copy link
Contributor

sg- commented Jul 6, 2016

LGTM 👍

@sg- sg- removed the needs: work label Jul 6, 2016
@sg- sg- merged commit 36ff1f7 into ARMmbed:master Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants