More verrbose errors for JSON parsing #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| with open(fname, "rt") as f: | ||
| return dict_to_ascii(json.load(f, object_pairs_hook=OrderedDict)) | ||
| except ValueError: |
There was a problem hiding this comment.
I would add here IOError too, in case file can't be opened! :)
This commit adds information about the location of problematic JSON files when reporting a JSON parsing error. Before this commit: ``` [ERROR] Expecting property name: line 7 column 9 (char 188) ``` After this commit: ``` Error parsing 'core/mbed_lib.json': [ERROR] Expecting property name: line 7 column 9 (char 188) ```
bogdanm
force-pushed
the
verbose_json_errors
branch
from
d8c56d2 to
33dd3fe
Compare
|
Forced-pushed the change suggested by @PrzemekWirkus |
|
👍 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds information about the location of problematic JSON
files when reporting a JSON parsing error.
Before this commit:
After this commit: