Skip to content

project - zip and src check if empty fix #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jul 18, 2016

Regression from #2179. Fixes #2184.

Before:

python tools\project.py -m KL25Z -p 0 -i gcc_arm

 * KL25Z::gcc_arm      C:\Code\git_repo\github\mbed\.build\export\.temp\MBED_A1

With this patch:

python tools\project.py -m KL25Z -p 0 -i gcc_arm

  * KL25Z::gcc_arm     mbed\.build\export\MBED_A1_gcc_arm_KL25Z.zip

@sarahmarshy @theotherjimmy @screamerbg

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 18, 2016

cc @ohagendorf

@sarahmarshy
Copy link
Contributor

I also pushed a fix, but this looks good. Sorry about that :/

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 18, 2016

@sarahmarshy Please test , I checked the previous logic. if this not bool is correct, and works also for --source

@ohagendorf
Copy link
Contributor

LGTM

@sarahmarshy
Copy link
Contributor

Tested with and without --source. Looks good.

@0xc0170 0xc0170 merged commit 9626ef3 into ARMmbed:master Jul 19, 2016
@0xc0170 0xc0170 deleted the fix_issue2184 branch July 19, 2016 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants