-
Notifications
You must be signed in to change notification settings - Fork 3k
ARM toolchain - add support for small-build #2210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Same as for GCC, if small-build is selected, select microlib library. This is currently duplicated from microlib. I assume we deprecate microlib toolchain, thus duplication should be removed.
Note: This can be considered breaking as it changes for targets with ARM toolchain support and defined |
Looks good to me but this can be a breaking change for some targets. |
@@ -81,6 +81,34 @@ def __init__(self, target, options=None, notify=None, macros=None, silent=False, | |||
self.ar = join(ARM_BIN, "armar") | |||
self.elf2bin = join(ARM_BIN, "fromelf") | |||
|
|||
# Use latest gcc nanolib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is a copy paste error from gcc.py ?
@mbed-bot: TEST HOST_OSES=windows |
[Build 662] |
Note: needs:work label is the same as DON'T MERGE YET , we can eliminate one of them. needs: work can be changed to red label. Back to the issue, the builds fail because of inconsistency. To provide small build, we use microlib for ARM, but microlib requires different startup file and many of targets do not support it. To complete this fix, we might need to unify this. An example for LPC1768 - diff between two startups (microbit and full std):
@c1728p9 You might be already looking at this, let me know |
@0xc0170, unfortunately I haven't looked in depth at the difference uARM and ARM startup files. This is something I definitely want to address in the future though. |
Great, in that case probably needs update based on the naming in 5197edc |
@0xc0170 anything left to get done here or is this still on hold? |
Tracking issue: #2902 . Closing this as it's old and should be reconsidered. |
Same as for GCC, if small-build is selected, select microlib library. This
is currently duplicated from microlib. I assume we deprecate microlib toolchain, thus
duplication should be removed (regarding extending cc/asm flags by --microlib, etc).
Tested with nrf51 microbit:
Exported project contains also microlib configuration (tested for NRF51 MICROBIT), and K64F (not containing single thread as its full stdlib
python tools\make.py -m K64F -t ARM -n RTOS_1
)This PR assumes we got GCC and ARM toolchains and provide small std lib option. Not as it is uARM vs ARM.
@c1728p9 @sg- @pan-