Introduce the lwip-interface into the core mbed repo #2231

geky · 2016-07-22T21:35:08Z

This patch introduces the network-socket API compatible lwip-interface into the core mbed repo.

dir features/net/FEATURE_IPV4/lwip-interface
related #2216
cc @sg-, @c1728p9

Responded to feedback from mbed-client implementation to introduce a full feature set that should support most of the use cases for the API.

@c1728p9

The size was increased to 4 bytes. Thanks @c1728p9 for spotting this.

Move the backend of LWIPInterface from the LWIP socket API to the asynch UDP/TCP APIs used in https://github.com/armmbed/sal-stack-lwip. Provides asynchronous functionality for the LWIPInterface.

Pros - Simplifies interface - Easier base implementation Cons - May need shutdown functionality, in this case shutdown can be added as another function in the future

Pros - Easier to implement - More similar to SIGIO in BDS sockets Cons - Less information, but this information had a high risk of being faulty/spurious

- socket_create -> socket_open - socket_destroy -> socket_close

Adds the following functions for direct configuration of interface - (set|get)stackopt - (set|get)sockopt

NetworkInterface -> NetworkStack EthernetInterface -> EthernetStack WiFiInterface -> WiFiStack CellularInterface -> CellularStack MeshInterface -> MeshStack

mirrored from: https://developer.mbed.org/teams/NetworkSocketAPI/code/LWIPInterface/

Remove all the hal files in preparation for pulling in mbedmicro/mbed.

Sync the directory lwip-eth with that of mbedmicro/mbed at revision b32f7a9.

@return

per the socket API documentation: /** Get the local IP address * * @return Null-terminated representation of the local IP address * or null if not yet connected */ virtual const char *get_ip_address() = 0; LWIPInterface incorrectly returned "\0" if unconnected

@LiyouZhou

- Semaphore returns 0 on timeout, and negative was incorrect used for errors - Correctly checked error code on tcp_connect thanks to @LiyouZhou fixes ARMmbed#284, fixes ARMmbed#285, fixes ARMmbed#166

For very slow networks the previous default has be problematically short

Don't have GCC_ARM use GCC_CR's memory region in mem.c. This fixes some tests.

…plicate file names when exporting.

Refactor LWIPInterface so it is a NetworkInterface rather than a NetworkStack. Rename LWIPInterface to EthernetInterface since it is no longer a stack. Update tests to use this new name.

* NUCLEO_F746ZG : enable Ethernet and LwIP for this target. Net tests were passed : mbed-os-features-feature_ipv4-tests-mbedmicro-net-nist_internet_time_service | OK mbed-os-features-feature_ipv4-tests-mbedmicro-net-tcp_client_hello_world | OK The 2 other are failing because I cannot test them on my ST computer.

@cyliangtw

per @cyliangtw

- lwip socket api did not provide signaling mechanism compatible with mutliple stacks - lwip raw api did not support multiple threads The netconn api provides the necessary signalling mechanism while still supporting multiple threads. The netconn api also shares several design similarities to the current socket api. Additionally, the move to a higher-level api reduced implementation complexity significantly and will hopefully reduce integration difficulties

- Renamed LWIPInterface to LWIPStack - Moved LWIPStack to static declaration - Removed hidden comments - Reduced lwip includes

Globally declared C++ classes with vtables are not gced by current toolchains, even if the C++ class contains no member variables and no constructor. This causes all of lwip to be dragged into resulting binaries, even if lwip is not accessed. Adoption of the SingletonPtr class in lwip allows us to workaround this issue.

- Removes problem with non-gced vtables - Moves some tedius operations up into the nsapi

…858cf3de3678aea4deec941add516790' git-subtree-dir: features/net/FEATURE_IPV4/lwip-interface git-subtree-mainline: 83f24fb git-subtree-split: 63e816f

sg- · 2016-07-22T22:24:18Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE

sg- · 2016-07-22T22:27:19Z

/morph test

mbed-bot · 2016-07-22T22:40:08Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 481

A build failure occurred!

mbed-bot · 2016-07-22T22:48:01Z

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

sg- · 2016-07-22T22:55:35Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE

sg- · 2016-07-22T22:56:16Z

/morph test

bridadan · 2016-07-22T23:17:27Z

I'm already seeing an issue with lwip_stack.c for the target NUCLEO_F746ZG.

It boiled down to not having stdbool.h and string.h included in the file. The K64F and other lwip platforms must do this in their hal somewhere so it didn't get caught there.

@geky Could these two includes be added to lwip_stack.c?

mbed-bot · 2016-07-22T23:20:01Z

[Build 681]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

mbed-bot · 2016-07-22T23:23:09Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 484

A build failure occurred!

c1728p9 · 2016-07-22T23:36:04Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE

sg- · 2016-07-22T23:41:22Z

/morph test

geky · 2016-07-22T23:59:29Z

Ah yeah, thanks @c1728p9!

mbed-bot · 2016-07-23T00:37:29Z

[Build 684]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

sg- · 2016-07-23T00:38:32Z

/morph test

mbed-bot · 2016-07-23T01:34:00Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 487

A test failure occurred!

sg- · 2016-07-23T04:19:24Z

LGTM 👍 Failures are know test execution failures.

Bogdan Marinescu and others added 30 commits July 22, 2016 02:02

Preparing new layout - moving lwip

b032d18

Matched changes NetworkSocketAPI

697ac55

Responded to feedback from mbed-client implementation to introduce a full feature set that should support most of the use cases for the API.

lwip - fix size of sys mutex for RTX 4.79

498add7

The size was increased to 4 bytes. Thanks @c1728p9 for spotting this.

Move to asynch lwip sockets based on armmbed/sal-stack-lwip

a25aeea

Move the backend of LWIPInterface from the LWIP socket API to the asynch UDP/TCP APIs used in https://github.com/armmbed/sal-stack-lwip. Provides asynchronous functionality for the LWIPInterface.

Remove shutdown parameter from close call

41d7277

Pros - Simplifies interface - Easier base implementation Cons - May need shutdown functionality, in this case shutdown can be added as another function in the future

Move to single state-change interrupt

db8495c

Pros - Easier to implement - More similar to SIGIO in BDS sockets Cons - Less information, but this information had a high risk of being faulty/spurious

Renamed NetworkInterface create/destroy methods to match Socket methods

e47bb97

- socket_create -> socket_open - socket_destroy -> socket_close

Added better support for SocketAddress/string addresses/ports

1aa0b6c

Revised stack specific configurations

e51f157

Adds the following functions for direct configuration of interface - (set|get)stackopt - (set|get)sockopt

Standardized comment style

3850933

Rename Interface -> Stack

def3b40

NetworkInterface -> NetworkStack EthernetInterface -> EthernetStack WiFiInterface -> WiFiStack CellularInterface -> CellularStack MeshInterface -> MeshStack

Separate Stack/Interface concept into two distinct classes

a7c0799

Match changes to NSAPI in LWIPInterface

0d0d008

mirrored from: https://developer.mbed.org/teams/NetworkSocketAPI/code/LWIPInterface/

Add rudimentary support for server side

a263b91

mirrored from: https://developer.mbed.org/teams/NetworkSocketAPI/code/LWIPInterface/

Incrase netif_up semaphore timeout from 1500ms to 2500ms

c9d0447

Remove hal

59f444f

Remove all the hal files in preparation for pulling in mbedmicro/mbed.

Pull in lwip-eth updates from mbedmicro/mbed

3b32e53

Sync the directory lwip-eth with that of mbedmicro/mbed at revision b32f7a9.

Fixed uninitialized port in lwip dragged in by KSDK2

05b21d7

Added support for NSAPI_KEEPALIVE in LWIPInterface

b251c59

Implement the NSAPI_KEEPINTVL in the LWIPInterface

864c73b

Added NSAPI_KEEPIDLE option to the socket API and LWIPInterface

5334934

Added handling for already connected sockets in LWIPInterface::connect

df5c05f

Fixed incorrect semaphore handling on lwip connect and socket_connect

d82bbb1

- Semaphore returns 0 on timeout, and negative was incorrect used for errors - Correctly checked error code on tcp_connect thanks to @LiyouZhou fixes ARMmbed#284, fixes ARMmbed#285, fixes ARMmbed#166

Increased lwip connect timeout to 5 seconds by default

68365a9

For very slow networks the previous default has be problematically short

add IAR placement for LPC1768 and lwip buffers

f4e3ab4

added default placement macro for all boards and toolchains

89d02fa

Fix LPC1768 tests

3fe5d32

Don't have GCC_ARM use GCC_CR's memory region in mem.c. This fixes some tests.

add lwip to all c files that come from the lwip codebase to reduce du…

6762ead

…plicate file names when exporting.

Separate interface from stack for ethernet

35ca7d1

Refactor LWIPInterface so it is a NetworkInterface rather than a NetworkStack. Rename LWIPInterface to EthernetInterface since it is no longer a stack. Update tests to use this new name.

adustm and others added 9 commits July 22, 2016 02:02

Added stddef.h include to cc.h in lwip for size_t define

41629b4

per @cyliangtw

Moved to static declaration of LWIPStack and refactored a bit

3b20e4b

- Renamed LWIPInterface to LWIPStack - Moved LWIPStack to static declaration - Removed hidden comments - Reduced lwip includes

Adopted nsapi header in lwip

f49aa23

Adopted the nsapi_socket_t type in lwip

a40c23d

Adopted nsapi_stack_t in lwip

63e816f

- Removes problem with non-gced vtables - Moves some tedius operations up into the nsapi

Add 'features/net/FEATURE_IPV4/lwip-interface/' from commit '63e816f0…

1fcc023

…858cf3de3678aea4deec941add516790' git-subtree-dir: features/net/FEATURE_IPV4/lwip-interface git-subtree-mainline: 83f24fb git-subtree-split: 63e816f

geky mentioned this pull request Jul 22, 2016

Move FEATURE_IPV6 from mbed-os to here. #2207

Closed

Add includes so lwip compiles

ebf42f0

sg- merged commit db99e72 into ARMmbed:master Jul 23, 2016

Introduce the lwip-interface into the core mbed repo #2231

Introduce the lwip-interface into the core mbed repo #2231

Uh oh!

Conversation

geky commented Jul 22, 2016

Uh oh!

sg- commented Jul 22, 2016

Uh oh!

sg- commented Jul 22, 2016

Uh oh!

mbed-bot commented Jul 22, 2016

Result: FAILURE

Output

Uh oh!

mbed-bot commented Jul 22, 2016

Uh oh!

sg- commented Jul 22, 2016

Uh oh!

sg- commented Jul 22, 2016

Uh oh!

bridadan commented Jul 22, 2016

Uh oh!

mbed-bot commented Jul 22, 2016

Uh oh!

mbed-bot commented Jul 22, 2016

Result: FAILURE

Output

Uh oh!

c1728p9 commented Jul 22, 2016

Uh oh!

sg- commented Jul 22, 2016

Uh oh!

geky commented Jul 22, 2016

Uh oh!

mbed-bot commented Jul 23, 2016

Uh oh!

sg- commented Jul 23, 2016

Uh oh!

mbed-bot commented Jul 23, 2016

Result: FAILURE

Output

Uh oh!

sg- commented Jul 23, 2016

Uh oh!

Uh oh!