Client nanostack and seperated #2249

c1728p9 · 2016-07-26T03:11:43Z

Combine #2207 and #2246 into one PR and restructure so client and nanostack do not depend on each other.

Contains same version of libraries as ARMmbed#453 Tagged versions * mbed-mesh-api mbed-os-5.0-rc1 * mbed-trace mbed-os-5.0-rc1 * nanostack-hal-cmsis-rtos mbed-os-5.0-rc1 * nanostack-interface copied. no remote repository * nanostack-libservice mbed-os-5.0-rc1 * sal-stack-nanostack mbed-os-5.0-rc1 Binaries generated from v5.0.5 The M3 build is used for both M3 and M4 devices.

Replacing with source code replicated from respective repositories including mbed-client - TAG mbed-os-5.0-rc1 mbed-client-c - TAG mbed-os-5.0-rc1 mbed-client-classic - TAG mbed-os-5.0-rc2 mbed-client-mbed-tls - TAG mbed-os-5.0-rc1 mbed-client-randlib - TAG mbed-os-5.0-rc1 coap-service - TAG mbed-os-5.0-rc1 Adding CONTRIBUTING.md file explaining how to submit patches for any of the components belonging to FEATURE_CLIENT

c1728p9 · 2016-07-26T03:12:46Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

c1728p9 · 2016-07-26T03:12:49Z

/morph test

mbed-bot · 2016-07-26T03:13:27Z

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

c1728p9 · 2016-07-26T03:14:45Z

This should also address #406.
CC: @SeppoTakalo, @yogpan01, @kjbracey-arm

sg- · 2016-07-26T03:16:40Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

mbed-bot · 2016-07-26T04:10:17Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 517

Test failed!

c1728p9 · 2016-07-26T04:31:41Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

c1728p9 · 2016-07-26T04:32:44Z

/morph test

sg- · 2016-07-26T04:36:02Z

@bridadan @PrzemekWirkus Looks like an erroneous failure for 517 running tests-mbedmicro-rtos-mbed-queue on IAR and K64F. Can you confirm?

Move the library files used by both nanostack and client into a common location. This allows both client and nanostack to be built stand-alone. The patch moves the following libraries into a common location: -mbed-client-c -mbed-client-randlib -mbed-trace -nanostack-hal-mbed-cmsis-rtos -nanostack-libservice -sal-stack-nanostack-eventloop And moves the library 'coap-service' from client into nanostack.

mbed-bot · 2016-07-26T05:07:57Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 520

Test Prep failed!

sg- · 2016-07-26T05:31:54Z

/morph test

sg- · 2016-07-26T05:32:16Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

mbed-bot · 2016-07-26T05:43:12Z

[Build 701]
FAILURE: Something went wrong when building and testing.

SeppoTakalo · 2016-07-26T09:01:38Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=K64F

mbed-bot · 2016-07-26T09:10:06Z

[Build 706]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

SeppoTakalo · 2016-07-26T09:40:21Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM
TARGETS=K64F

mbed-bot · 2016-07-26T09:48:27Z

[Build 707]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

SeppoTakalo · 2016-07-26T10:07:18Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=IAR
TARGETS=K64F

mbed-bot · 2016-07-26T10:15:32Z

[Build 708]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

SeppoTakalo · 2016-07-26T10:26:08Z

I tested this PR with mbed-os-example-client and some weird behaviour appears.
Program starts only once after a flash and stops immediately. Then reset button does not restart.
No packets appear on the network (6LoWPAN).

Starting mbed Client example...
Using Mesh

Connecting to Mesh..

Nothing appears after that.
What have been done? This was working 12 hours ago.

SeppoTakalo · 2016-07-26T10:43:30Z

Oh.. LOL, my problem.

I was using a wrong build target and my flash script picked it up and flashed the device twice

With correct target seems to be working fine.

Starting mbed Client example...
Using Mesh

Connecting to Mesh..

Connected to Network successfully
IP address 2001:999:11:b6b3:fec2:3d00:4:a2ac

SOCKET_MODE : UDP
Connecting to coaps://[2607:f0d0:2601:52::20]:5684

Registered object successfully!

SeppoTakalo · 2016-07-26T11:31:57Z

By separating the IPV6 to PAL we gained following:

Using Ethernet

Configuration	Flash size
`["CLIENT", "COMMON_PAL"]`	315995
`["CLIENT", "COMMON_PAL", "IPV6"]` and Atmel RF driver	315987
diff	-8

Good thing is that now we can build without RF driver present. This however, should be still done to IPv6 feature anyway, but later.

SeppoTakalo · 2016-07-26T11:33:45Z

I don't know about CI status, but from our point of view, this is ready to go in.

I would recommend merging this PR, instead of the separated Client+IPV6 PRS.

yogpan01 · 2016-07-26T13:02:09Z

This should be now good to be merged.

bridadan · 2016-07-26T14:30:19Z

/morph test

SeppoTakalo · 2016-07-26T14:31:35Z

@c1728p9
Just noticed one thing, in order to prepare the baseline change, one change is needed.

This repo does not anymore contain the features/wrapper/mbed-drivers/mbed.h so references to mbed-drivers/mbed.h need to be changed to mbed.h
This is undocumented change, so I'm unsure if you are planning to bring that wrapper in, or not.

Can you go through references of in this repo and change them as I have no RW access to this PR. There was number of them in mbed-mesh-api

I would however recommend to bring that wrapper in, as it allows some code to compile on both mbed OS 5 and 3.

sg- · 2016-07-26T14:41:58Z

@c1728p9 please grep the whole tree and update all to mbed.h

@SeppoTakalo please update the origin to only use mbed.h Sorry if this wasn't previously shared.

mbed-bot · 2016-07-26T15:21:47Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 524

Test failed!

Include mbed.h rather than mbed-drivers/mbed.h.

bridadan · 2016-07-26T17:35:24Z

/morph test

mbed-bot · 2016-07-26T18:23:32Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 526

Test failed!

sg- · 2016-07-26T18:36:38Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE

mbed-bot · 2016-07-26T19:01:23Z

[Build 712]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

Seppo Takalo and others added 4 commits July 25, 2016 21:47

Update nanostack-hal-cmsis-rtos.

475cda0

Move FEATURE_IPV6 under features/net

359dc05

c1728p9 force-pushed the client_nanostack_and_seperated branch from e0f88ad to 035aa85 Compare July 26, 2016 04:31

c1728p9 force-pushed the client_nanostack_and_seperated branch from 035aa85 to cef844f Compare July 26, 2016 05:00

SeppoTakalo mentioned this pull request Jul 26, 2016

Fix documentation for current IPV6 separation. ARMmbed/mbed-os-example-client#43

Merged

Update client and nanostack to include mbed.h

9c01bbc

Include mbed.h rather than mbed-drivers/mbed.h.

sg- merged commit 5d73176 into ARMmbed:master Jul 26, 2016

This was referenced Jul 26, 2016

Move mbed-os/features/FEATURE_CLIENT to mbed/features/FEATURE_CLIENT #2205

Closed

Move FEATURE_IPV6 from mbed-os to here. #2207

Closed

Client nanostack and seperated #2249

Client nanostack and seperated #2249

Uh oh!

Conversation

c1728p9 commented Jul 26, 2016

Uh oh!

c1728p9 commented Jul 26, 2016

Uh oh!

c1728p9 commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Uh oh!

c1728p9 commented Jul 26, 2016

Uh oh!

sg- commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Result: FAILURE

Output

Uh oh!

c1728p9 commented Jul 26, 2016

Uh oh!

c1728p9 commented Jul 26, 2016

Uh oh!

sg- commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Result: FAILURE

Output

Uh oh!

sg- commented Jul 26, 2016

Uh oh!

sg- commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

yogpan01 commented Jul 26, 2016

Uh oh!

bridadan commented Jul 26, 2016

Uh oh!

SeppoTakalo commented Jul 26, 2016

Uh oh!

sg- commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Result: FAILURE

Output

Uh oh!

bridadan commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Result: FAILURE

Output

Uh oh!

sg- commented Jul 26, 2016

Uh oh!

mbed-bot commented Jul 26, 2016

Uh oh!

Uh oh!