Fix MAIN_THREAD_ID check #2259
Merged
Fix MAIN_THREAD_ID check #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cmsis_os.h OS_TIMERS is undefined unless the timer thread is disabled, in which case it is defined to 0. When comparing against an undefined value, the undefined value will evaluate as if it were 0. Because of this the MAIN_THREAD_ID was always set to 0x1. This patch fixes that problem by checking if OS_TIMERS is defined before comparing it to 0. This problem only effects IAR since it has a different heap/stack layout. GCC_ARM and ARM have a dedicated stack region so the presence of a guard word and stack checking does not cause problems. This problem manifested on the NRF51_DK in the pull request ARMmbed#2211 as a c_strings test failure on floating point. This is because the guard word of the main stack overlapped with standard library data used by sprintf and corrupted it.
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 718] |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 533 Test failed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cmsis_os.h OS_TIMERS is undefined unless the timer thread is
disabled, in which case it is defined to 0. When comparing against
an undefined value, the undefined value will evaluate as if it were
0. Because of this the MAIN_THREAD_ID was always set to 0x1.
This patch fixes that problem by checking if OS_TIMERS is defined
before comparing it to 0.
This problem only effects IAR since it has a different heap/stack
layout. GCC_ARM and ARM have a dedicated stack region so
the presence of a guard word and stack checking does not cause
problems.
This problem manifested on the NRF51_DK in the pull request
#2211
as a c_strings test failure on floating point. This is because the
guard word of the main stack overlapped with standard library
data used by sprintf and corrupted it.