Skip to content

Added GCC_ARM for NUCLEO_F401RE #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2014
Merged

Added GCC_ARM for NUCLEO_F401RE #229

merged 2 commits into from
Apr 2, 2014

Conversation

todor603
Copy link

No description provided.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2014

Hello todor603,

why did you remove DISCO targets from the targets script? I believe you only were to add GCC_ARM to F401RE.

Regards,
0xc0170

@todor603
Copy link
Author

Hi there,

well, I didn't. At least not intentionally. I guess the DISCO was
recently added and I've used a week or so old version of targets.py.
I've copied out of my older repo without much checking. I tried to
provide the change after spending 7h in work and then 5h on the road.
Sorry for that.
Todor

Martin Kojtal wrote:

Hello todor603,

why did you remove DISCO targets from the targets script? I believe you
only were to add GCC_ARM to F401RE.

Regards,
0xc0170


Reply to this email directly or view it on GitHub
#229 (comment).

@bogdanm
Copy link
Contributor

bogdanm commented Mar 25, 2014

Hi Todor,

That's alright, you can update the pull request after you apply your patch on top of our latest master.
Also, have you accepted the mbed contributor's agreement at https://mbed.org/contributor_agreement ? It's a required step for all mbed contributors.

Thanks,
Bogdan

@todor603
Copy link
Author

todor603 commented Apr 2, 2014

Hi Bogdan,

I've accepted the agreement and changed targets.py to the latest version.
Todor

@bogdanm
Copy link
Contributor

bogdanm commented Apr 2, 2014

Thanks a lot!

bogdanm added a commit that referenced this pull request Apr 2, 2014
Added GCC_ARM for NUCLEO_F401RE
@bogdanm bogdanm merged commit f7c0e77 into ARMmbed:master Apr 2, 2014
pan- pushed a commit to pan-/mbed that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants