Enforcing 'standard' build for version 5 release #2300
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridadan
force-pushed
the
enforce-standard-boards-v5
branch
from
96bd3c3 to
4a7da3f
Compare
|
Never mind, these boards have since been switched to a |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 557 All builds and test passed! |
This PR enforces that the default_build in a target's definition in hal/targets.json is set to standard to be included in the version 5 release. This is being enforced because small builds do not support multi-threading. This makes the capabilities more consistent across all boards in the version 5 release. NOTE: This removes the MOTE_L152RC and the LPC11U68 from the version 5 release list because the 'default_build' for these targets is currently set to 'small'.
bridadan
force-pushed
the
enforce-standard-boards-v5
branch
from
4a7da3f to
7a07c38
Compare
|
Ok, removed the change to the two Nordic boards. /morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 558 Test failed! |
|
as I see it, just two LPC targets were removed. Any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces that the
default_buildin a target's definition inhal/targets.jsonis set tostandardto be included in the version 5 release.This is being enforced because
smallbuilds do not support multi-threading. This makes the capabilities more consistent across all boards in the version 5 release.NOTE: This removes the MOTE_L152RC and the LPC11U68
from the version 5 release list because the 'default_build' for these
targets is currently set to 'small'.