[tools] Fixed infinite loop in config scan due to list comparison error #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a scanning for config terminated on comparison of the feature set, however at some point the set was changed to a list. This resulted in non-deterministic failures based on list order.
Unlike other libraries, uvisor is currently integrated into the build system, with special cases based on its addition as a feature. This suggests we should also have tests for these special cases.
This was referenced Jul 29, 2016
|
/morph test |
|
Great! LGTM |
|
Build and test were all green! LGTM |
|
Thanks for the fix! I can confirm that this fixes #2312. 👍 |
|
BTW, not sure why the commit status wasn't set for |
|
Ok then, LGTM? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed infinite loop in config scan due to list comparison error.
Previously a scanning for config terminated on comparison of the feature set, however at some point the set was changed to a list. This resulted in non-deterministic failures based on list order.
Added a test specifically for the uvisor feature_add, which revealed the issue.
fixes #2312
cc @AlessandroA