Skip to content

Shortned nrf51 sdk paths #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2016
Merged

Shortned nrf51 sdk paths #2346

merged 2 commits into from
Aug 3, 2016

Conversation

pan-
Copy link
Member

@pan- pan- commented Aug 2, 2016

This should fix #2236 .
Basically, unneeded transition folders in NRF51 SDK have been removed.

pan- added 2 commits August 2, 2016 22:29
Move content from sources/nordic_sdk/components to sources.
@pan-
Copy link
Member Author

pan- commented Aug 2, 2016

@c1728p9 @screamerbg Could you check this PR ?

@bridadan
Copy link
Contributor

bridadan commented Aug 2, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Aug 2, 2016

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 584

Test failed!

@bridadan
Copy link
Contributor

bridadan commented Aug 3, 2016

Tests actually looked ok, there was a bit of hiccup with the K64F on GCC_ARM but the test output looks ok.

@c1728p9
Copy link
Contributor

c1728p9 commented Aug 3, 2016

Looks good to me. Reduces the max path length by ~28 characters.
from

len 74: sdk\source\softdevice\common\softdevice_handler\softdevice_handler_appsh.c

to

len 102: nrf51-
sdk\source\nordic_sdk\components\softdevice\common\softdevice_handler\softdevice_handler_appsh.c

@sg- sg- merged commit 4fd188f into ARMmbed:master Aug 3, 2016
@pan- pan- deleted the shortned_nrf51_sdk_paths branch September 27, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to BLE files for target NRF51822 is too long
5 participants