Expose the network-socket API through mbed.h #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this uses the same mechanism used by the rtos to conditionally include the network-socket API. Perhaps this should be builtin to the config system? Note: this does require that the bug-compatible inclusion of mbed.h be removed to avoid include-order issues. per @sg-
geky
changed the title
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=windows |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 606 Build failed! |
Before: m2mconnectionhandlerpimpl.cpp -> Socket.h -> mbed.h Now: m2mconnectionhandlerpimpl.cpp -> mbed.h
|
/morph test |
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 774] |
|
[Build 775] |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 607 All builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this uses the same mechanism used by the rtos to conditionally include the network-socket API. Perhaps this should be builtin to the config system?
Note: this does require that the bug-compatible inclusion of mbed.h be removed to avoid include-order issues, this may cause issues with existing examples. I will look into how this impacts mbed-os-example-client.
cc @sg-