Fix docs/BUILDING.md error #2382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
kclin
changed the title
|
@AlessandroA @meriac @niklas-arm please look at the 58ec5cd if it's correct |
|
@kclin Thank you for spotting the inconsistencies. Unfortunately I had to create a new commit for the uVisor README (see #2387) because we maintain the guide in the uVisor repository and then import it automatically using the uVisor importer script in this repository. Could you please remove 58ec5cd from this PR? Thank you! |
|
@AlessandroA understood. remove 58ec5cd done. Thanks for your review |
kclin
changed the title
|
LGTM, thanks for rebasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description used in BUILDING.md does not work. It works with -L parameter