Changed error(...) to a weak function #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made error(...) a weak function so that it can be overridden in production projects. Also fixed several serial_api.c files that required stdlib.h, but were getting it from error.h.
| @@ -16,6 +16,7 @@ | |||
| // math.h required for floating point operations for baud rate calculation | |||
| #include <math.h> | |||
| #include <string.h> | |||
| #include <stdlib.h> | |||
|
Hello, A side note: you included notes, which is appreciated ! 👍 Thanks! Regarding those comments about abs() in serial code files, they could be actually merged into one or preferably stated in the commit message. Regards, |
|
Ah, sorry, I guess I went a little bit overboard. |
bogdanm
added a commit
that referenced
this pull request
Apr 1, 2014
Changed error(...) to a weak function
rajkan01
pushed a commit
to rajkan01/mbed-os
that referenced
this pull request
Mar 7, 2019
adbridge
pushed a commit
that referenced
this pull request
Apr 24, 2019
- Link to bug tracking: https://developer.trustedfirmware.org/T239 (cherry picked from commit 5f2e4b3)
adbridge
pushed a commit
that referenced
this pull request
May 3, 2019
- Link to bug tracking: https://developer.trustedfirmware.org/T239 (cherry picked from commit 5f2e4b3)
chrissnow
pushed a commit
to chrissnow/mbed-os
that referenced
this pull request
May 15, 2019
- Link to bug tracking: https://developer.trustedfirmware.org/T239 (cherry picked from commit 5f2e4b3)
urutva
pushed a commit
to urutva/mbed-os
that referenced
this pull request
May 31, 2019
- Link to bug tracking: https://developer.trustedfirmware.org/T239 (cherry picked from commit 5f2e4b3) (cherry picked from commit 5d41a2a)
urutva
pushed a commit
to urutva/mbed-os
that referenced
this pull request
Jun 13, 2019
- Link to bug tracking: https://developer.trustedfirmware.org/T239 (cherry picked from commit 5f2e4b3) (cherry picked from commit 5d41a2a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made error(...) a weak function so that it can be overridden in production projects. Also fixed several serial_api.c files that required stdlib.h, but were getting it from error.h.