Fix possible overflow of NRF51 os tick. #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RTC1 counter can increase while the new value for the CC register used by the os tick is computed. As a result, when interrupts are enabled again RTC1 counter and CC register value are equal. If these two values are equal then the interrupt for the CC channel used by the OS tick will be generated the next time the RTC counter reach that value. In other words, the next OS tick will occur 131 seconds latter. This issue possibly concern all NRF51 targets with 32K of RAM but is only visible on NRF51_DK target when their is heavy BLE load.
|
@0xc0170 Could you review this ? |
|
@mbed-bot: TEST HOST_OSES=windows |
|
LGTM Jenkins failed as it could not checkout the sha, can't tell why. I run another CI job |
|
[Build 793] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTC1 counter can increase while the new value for the CC register
used by the os tick is computed. As a result, when interrupts are enabled
again RTC1 counter and CC register value are equal. If these two values are
equal then the interrupt for the CC channel used by the OS tick will be
generated the next time the RTC counter reach that value.
In other words, the next OS tick will occur 131 seconds latter.
This issue possibly concern all NRF51 targets with 32K of RAM but is
only visible on NRF51_DK target when their is heavy BLE load.