Skip to content

Fixes from master #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2016
Merged

Fixes from master #2413

merged 7 commits into from
Aug 11, 2016

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 10, 2016

I compared master to 5.1 branch, created a patch with all commits that are bugfixes (unified wait is not here).

cc @sg- @c1728p9 @bogdanm

evark and others added 7 commits August 10, 2016 15:40
Add support for the arduino form factor in targets.json for the
NUCLEO_F429ZI.
Note: The README is auto-generated by the importer script, which copies
the QUICKSTART.md guide from ARMmbed/uvisor.
This follows:

ARMmbed/uvisor#02ecf05 - "Remove unused TFN_RPC_Callback"
ARMmbed/uvisor#483ddda - "rpc: Add `rpc_fncall_wait`"
ARMmbed/uvisor#fdb7dce - "rpc: Add missing UVISOR_EXTERN to
                          rpc_fncall_waitfor declaration"
When a thread is terminated signal the join semaphore so any threads
joining the terminated thread wake up as expected.
@bogdanm
Copy link
Contributor

bogdanm commented Aug 10, 2016

👍

@sg-
Copy link
Contributor

sg- commented Aug 10, 2016

/morph test

@sg-
Copy link
Contributor

sg- commented Aug 10, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=ALL

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 625

Test failed!

@mbed-bot
Copy link

[Build 794]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

One test box was having issues, making patches now. I can rerun this after if need be.

Thing to note, the morph bot always merges with master, not the branch you're submitting against. Is that still useful in this case?

@sg-
Copy link
Contributor

sg- commented Aug 10, 2016

Thing to note, the morph bot always merges with master, not the branch you're submitting against. Is that still useful in this case?

Nope :) Can the merge happen against the tip of the branch that is trying to be merged into? In general seems this should be the case. Is it possible?

@bridadan
Copy link
Contributor

Oh yeah definitely possible, just not implemented yet. Need to spend some time on the bot today then (I've been meaning to that anyways).

@sg-
Copy link
Contributor

sg- commented Aug 11, 2016

@bridadan is this ready for some new testing to be ran?

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 631

All builds and test passed!

@bridadan
Copy link
Contributor

@sg- I added the ability for the bot to detect which branch the PR is submitted against and merge it with that branch. The most recent build on this PR did just that 👍

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 11, 2016

@bridadan @sg- Triggering only tests and not sharing the valuable output is not much helpful. I would appreciate if you also share what's the current status (review CI log). I am blocked by this in many cases.

For instance, here's my view: jenkins build - checkout failure (not relevant to this changeset), continuous-integration/mbedci - not relevant neither, failures known, the rest is OK

@sg- sg- merged commit c9a7f73 into ARMmbed:mbed-os-5.1 Aug 11, 2016
@bridadan
Copy link
Contributor

@0xc0170 The output for the CIs should be visible, are you not able to see them?

With regards to the jobs titled "Jenkins Build", I don't run those, that's done by @mazimkhan. @mazimkhan are there issues with the jobs?

With regards to continuous-integration/mbed-ci - we should either fix those errors or stop testing that board if we don't intend to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants