Fix k64f mcu - common code to be shared for k64f derivates #2428

0xc0170 · 2016-08-11T14:12:07Z

fixing K64F inheritance. This is causing a problems as GAMBIT or HEXIWEAR define K64F as a label ,thus our scripts go into TARGET_K64F -> duplicate symbols. IT used to be MCU_K64F but was renamed.

Note: we should not remove labels as I was told earlier, is this breaking change? 😭 It should not be as now we version targets.json with the code, should be safe :-)

I don't think this is a long term solution (the other platforms might have the same problem).

One more error to be fixed for gambit:

Error: L6218E: Undefined symbol PinMap_UART_CTS (referred from serial_api.o).
Error: L6218E: Undefined symbol PinMap_UART_RTS (referred from serial_api.o).
Finished: 0 information, 0 warning and 2 error messages.
[ERROR] Error: L6218E: Undefined symbol PinMap_UART_CTS (referred from serial_api.o).
Error: L6218E: Undefined symbol PinMap_UART_RTS (referred from serial_api.o).
Finished: 0 information, 0 warning and 2 error message

I am sending this to the release branch (one to do mbed SDK release), will be merged to mbed-os-5.1 and I'll propagate these fixes to master.

@bogdanm @sg- ANy other ideas how to quickly fix this? We shall consider something better for the next release. I dont like having MCU_K64F there but we need some common part for K64F, and because we got K64F as a target name, this is causing conflicts

This is common for any K64F not only for frdm-k64f that is named K64F. This is causing conflicts with inheritance. This might be fixed better (long term solution).

Plus protect serial flow in the common k64f code, as not all targets provide its support.

0xc0170 · 2016-08-11T14:18:38Z

I pushed a fix for gambit - removing serial flow control as it does not define pins required ( I can push it separately), just need to have all K64F in the building state here to be sure this does not break any K64F derivative.

bogdanm · 2016-08-11T15:05:00Z

LGTM, but I can't comment on the "don't remove labels from targets" issues.

bridadan · 2016-08-11T15:56:25Z

@0xc0170 This currently fails to build mbed OS 5 tests on the ARM toolchain for HEXIWEAR:

Building project test_setup_failure (HEXIWEAR, ARM)
Scan: ARM
Scan: test_setup_failure
Compile: main.cpp
Link: test_setup_failure
Error: L6218E: Undefined symbol serial_set_flow_control (referred from SerialBase.o)
Finished: 0 information, 0 warning and 1 error messages.

bridadan · 2016-08-11T17:06:52Z

/morph test

mbed-bot · 2016-08-11T17:45:08Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 634

Test Prep failed!

bridadan · 2016-08-11T18:25:36Z

Dang, I've been having issue where one of the test boxes crashes. The syslog ends up getting corrupted which it makes more exciting to track down.

I'm going to reboot the box and then restart this test to hopefully give you some results. I'll have to take the box down and reimage after that.

bridadan · 2016-08-11T18:35:26Z

I ran the tests on the HEXIWEAR on all the toolchains, all passing!

bridadan · 2016-08-11T20:21:16Z

@0xc0170 I reran the tests manually from Jenins since the build was good, all the tests are passing!

+1

bridadan · 2016-08-11T21:52:54Z

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,IAR,GCC_ARM
TARGETS=HEXIWEAR,K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

mbed-bot · 2016-08-11T22:30:21Z

[Build 803]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

0xc0170 · 2016-08-12T03:45:58Z

Tests are OK, I'll merge this. this changeset is applied only to targets that has not yet been released.

…..91acece 91acece Remove test files 6568bc1 Merge branch 'release_internal' into release_external 4192cc8 Added configuration for RADIUS retry timer (ARMmbed#2438) 684b714 Added support for retries and multiple sockets to RADIUS client (ARMmbed#2426) 89e0ae0 WS: Restart auto CCA threshold after discovery (ARMmbed#2435) dbb09b1 MAC/WS: Min possible Tack to 1ms and CCA interval to 2ms (ARMmbed#2434) 43b2ae2 Cca threshold test (ARMmbed#2436) 28108e1 Added device min sensitivity setting and stack information 7060c70 Cca threshold test (ARMmbed#2432) 640be71 WS: temporarily set default CCA threshold to -80 (ARMmbed#2431) 0a472ae WS: Calculate UFSI drift and trace (ARMmbed#2430) 61d3db8 Create APIs for DNS cache results 587add5 MAC: Validate TX time (ARMmbed#2429) a1bfed4 Added typecast when computing max_timout from drift (ARMmbed#2428) 089fb3b Neighbour temporary entry update and Enhanced ACK tx update 70244f6 Wi-sun parameter and debug trace update 5752eae Created validate TX time handler (ARMmbed#2423) 022d61f Wi-sun Neighbour table update and DHCP new callback 857b41f Merge pull request ARMmbed#2421 from ARMmbed/update_from_mbed_os 1a9dd13 (via Mbed-OS)WS Management API missing include 4318f37 Calculate drift in critical state (ARMmbed#2419) 01a1909 FHSS WS: Do not use drift compensation with unpredictable linux timer (ARMmbed#2418) git-subtree-dir: features/nanostack/sal-stack-nanostack git-subtree-split: 91acece

…..d879e6d d879e6d Merge branch 'release_internal' into release_external eef9246 Fixed network border router timeout recovery and EAPOL relay address fix bac7ca6 Changed RADIUS MTU and small fixes a9f8b75 Addeed support for DHCP vendor data d8f0003 DHCPv6 functionality update 7fe0423 Added DHCPv6 vendor data generation for DNS queries 639f9db FHSS: Changed retry backoffs when no BC schedule or TX slots (ARMmbed#2440) 91acece Remove test files 6568bc1 Merge branch 'release_internal' into release_external 4192cc8 Added configuration for RADIUS retry timer (ARMmbed#2438) 684b714 Added support for retries and multiple sockets to RADIUS client (ARMmbed#2426) 89e0ae0 WS: Restart auto CCA threshold after discovery (ARMmbed#2435) dbb09b1 MAC/WS: Min possible Tack to 1ms and CCA interval to 2ms (ARMmbed#2434) 43b2ae2 Cca threshold test (ARMmbed#2436) 28108e1 Added device min sensitivity setting and stack information 7060c70 Cca threshold test (ARMmbed#2432) 640be71 WS: temporarily set default CCA threshold to -80 (ARMmbed#2431) 0a472ae WS: Calculate UFSI drift and trace (ARMmbed#2430) 61d3db8 Create APIs for DNS cache results 587add5 MAC: Validate TX time (ARMmbed#2429) a1bfed4 Added typecast when computing max_timout from drift (ARMmbed#2428) 089fb3b Neighbour temporary entry update and Enhanced ACK tx update 70244f6 Wi-sun parameter and debug trace update 5752eae Created validate TX time handler (ARMmbed#2423) 022d61f Wi-sun Neighbour table update and DHCP new callback 857b41f Merge pull request ARMmbed#2421 from ARMmbed/update_from_mbed_os 1a9dd13 (via Mbed-OS)WS Management API missing include 4318f37 Calculate drift in critical state (ARMmbed#2419) 01a1909 FHSS WS: Do not use drift compensation with unpredictable linux timer (ARMmbed#2418) git-subtree-dir: features/nanostack/sal-stack-nanostack git-subtree-split: d879e6d

…8609ae..d879e6d d879e6d Merge branch 'release_internal' into release_external eef9246 Fixed network border router timeout recovery and EAPOL relay address fix bac7ca6 Changed RADIUS MTU and small fixes a9f8b75 Addeed support for DHCP vendor data d8f0003 DHCPv6 functionality update 7fe0423 Added DHCPv6 vendor data generation for DNS queries 639f9db FHSS: Changed retry backoffs when no BC schedule or TX slots (ARMmbed#2440) 91acece Remove test files 6568bc1 Merge branch 'release_internal' into release_external 4192cc8 Added configuration for RADIUS retry timer (ARMmbed#2438) 684b714 Added support for retries and multiple sockets to RADIUS client (ARMmbed#2426) 89e0ae0 WS: Restart auto CCA threshold after discovery (ARMmbed#2435) dbb09b1 MAC/WS: Min possible Tack to 1ms and CCA interval to 2ms (ARMmbed#2434) 43b2ae2 Cca threshold test (ARMmbed#2436) 28108e1 Added device min sensitivity setting and stack information 7060c70 Cca threshold test (ARMmbed#2432) 640be71 WS: temporarily set default CCA threshold to -80 (ARMmbed#2431) 0a472ae WS: Calculate UFSI drift and trace (ARMmbed#2430) 61d3db8 Create APIs for DNS cache results 587add5 MAC: Validate TX time (ARMmbed#2429) a1bfed4 Added typecast when computing max_timout from drift (ARMmbed#2428) 089fb3b Neighbour temporary entry update and Enhanced ACK tx update 70244f6 Wi-sun parameter and debug trace update 5752eae Created validate TX time handler (ARMmbed#2423) 022d61f Wi-sun Neighbour table update and DHCP new callback 857b41f Merge pull request ARMmbed#2421 from ARMmbed/update_from_mbed_os 1a9dd13 (via Mbed-OS)WS Management API missing include 4318f37 Calculate drift in critical state (ARMmbed#2419) 01a1909 FHSS WS: Do not use drift compensation with unpredictable linux timer (ARMmbed#2418) git-subtree-dir: connectivity/nanostack/sal-stack-nanostack git-subtree-split: d879e6d

0xc0170 added 4 commits August 11, 2016 14:58

Rename cmsis K64F to MCU_K64F

fbbb64a

This is common for any K64F not only for frdm-k64f that is named K64F. This is causing conflicts with inheritance. This might be fixed better (long term solution).

Target hexiwear - add mcu_k64f label

0b36174

K64F - HAL common part prefixed with MCU_K64F

1310bd1

MTS Gambit - remove serial flow control

cd9b178

Plus protect serial flow in the common k64f code, as not all targets provide its support.

K64F serial - fix device macro for serial flow

133d7b3

0xc0170 merged commit f1fb66c into ARMmbed:release Aug 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix k64f mcu - common code to be shared for k64f derivates #2428

Fix k64f mcu - common code to be shared for k64f derivates #2428

Uh oh!

0xc0170 commented Aug 11, 2016 •

edited

Loading

Uh oh!

0xc0170 commented Aug 11, 2016 •

edited

Loading

Uh oh!

bogdanm commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

mbed-bot commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

mbed-bot commented Aug 11, 2016

Uh oh!

0xc0170 commented Aug 12, 2016

Uh oh!

Uh oh!

Fix k64f mcu - common code to be shared for k64f derivates #2428

Fix k64f mcu - common code to be shared for k64f derivates #2428

Uh oh!

Conversation

0xc0170 commented Aug 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bogdanm commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

mbed-bot commented Aug 11, 2016

Result: FAILURE

Output

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

bridadan commented Aug 11, 2016

Uh oh!

mbed-bot commented Aug 11, 2016

Uh oh!

0xc0170 commented Aug 12, 2016

Uh oh!

Uh oh!

0xc0170 commented Aug 11, 2016 •

edited

Loading

0xc0170 commented Aug 11, 2016 •

edited

Loading