[tools!] Improve error for missing name from mbed_lib.json #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
changed the title
|
+1 cc @bogdanm |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 636 All builds and test passed! |
| @@ -241,6 +241,9 @@ def add_config_files(self, flist): | |||
| cfg = json_file_to_dict(f) | |||
| cfg["__config_path"] = full_path | |||
| # If there's already a configuration for a module with the same name, exit with error | |||
|
|
|||
| if "name" not in cfg: | |||
There was a problem hiding this comment.
Change is good, but the comment at line 243 (above) is confusing: it was supposed to apply to the next if (line 247 below).
theotherjimmy
force-pushed
the
better-config-errors
branch
from
7617495 to
71113a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2083
It now tells you something like