lwip: Allow several configuration macros to be set externally. #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows tuning of the lwIP TCP/IP stack e.g. via a "macros" clause in an mbed_app.json file, instead of requiring the user to modify the mbed-os source.
|
Can one of the admins verify this patch? |
|
Can comments be added to the amount of RAM a change in the defines will produce on they system? |
|
Agreed, comments such as you suggest would be useful. Guess I'll need to do some experimenting. |
|
@infinnovation When the investigation is done, please reopen. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file lwipopts.h defines various values configuring the lwIP library. These were chosen with quite small values, presumably to allow basic functionality but with a modest RAM footprint suitable for an embedded platform.
Depending on the application or target platform, a user may wish to modify the values, for example to allow more than 4 sockets open at once, or to increase the TCP window size for greater throughput.
By enclosing the existing settings within #ifndef/#endif, tuning of the lwIP TCP/IP stack can be achieved e.g. via a "macros" clause in an mbed_app.json file, instead of requiring the user to modify the mbed-os source.