Skip to content

Update uVisor with new page allocator #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2016
Merged

Update uVisor with new page allocator #2558

merged 3 commits into from
Aug 27, 2016

Conversation

meriac
Copy link
Contributor

@meriac meriac commented Aug 26, 2016

  • Adds a common interface for the implementation of the MPU region storage and scheduling.
  • Tested on both K64F and EFM32.

@sg- @AlessandroA @0xc0170 @c1728p9

@meriac
Copy link
Contributor Author

meriac commented Aug 26, 2016

/morph test

@@ -352,6 +347,7 @@ SECTIONS
}

/* Initializes stack on the end of block */
__StackTop = ORIGIN(m_data_2) + LENGTH(m_data_2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the stack was moved to the end of RAM. This should increase the heap size so +1.

Also, the GCC specific tweaks can now be removed in RTX_CM_Lib.h:

#if defined(__GNUC__) && !defined(__CC_ARM)     /* GCC */
extern uint32_t __StackTop[];
#define INITIAL_SP            (__StackTop)
#else
#define INITIAL_SP            (0x20030000UL)
#endif

@bridadan
Copy link
Contributor

@meriac You aren't currently on the white list for the morph bot, sorry about that! I have to do some maintenance on the test boxes today, so when that's done I'll add you to the whitelist. I'll trigger your PR as well.

@meriac
Copy link
Contributor Author

meriac commented Aug 26, 2016

@bridadan Thanks a lot! Can you please trigger a new test? I updated my pull request.

@meriac
Copy link
Contributor Author

meriac commented Aug 26, 2016

@sg- @c1728p9 @0xc0170 As recommended we reverted the K64F-specific StackTop-reference. Please trigger a test and merge.

@c1728p9
Copy link
Contributor

c1728p9 commented Aug 26, 2016

Looks good to me!

@sg-
Copy link
Contributor

sg- commented Aug 26, 2016

/morph test

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 726

Build Prep failed!

@bridadan
Copy link
Contributor

I had to abort the test temporarily as some infrastructure changes are going through right now, I'll retrigger them after I've verified things are ready to go.

@sg- sg- added the needs: CI label Aug 26, 2016
@bridadan
Copy link
Contributor

/morph test

@c1728p9
Copy link
Contributor

c1728p9 commented Aug 26, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 853]
FAILURE: Something went wrong when building and testing.

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 733

Test failed!

@bridadan
Copy link
Contributor

Morph tests look ok, all failing due to a known issue measuring timing-based tests on host PCs. 👍

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 855]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@bridadan
Copy link
Contributor

@sg- LGTM 👍

@sg- sg- merged commit eeead56 into ARMmbed:master Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants