lwip - Add checks for invalid state of network #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
force-pushed
the
nsapi-network-state
branch
from
57d1548 to
c483770
Compare
This was referenced Aug 26, 2016
- Check if disconnected in socket open - Check if connected in interface connect - Check if disconnected in interface disconnect
geky
force-pushed
the
nsapi-network-state
branch
from
c483770 to
98ec80c
Compare
|
@mbed-bot: TEST HOST_OSES=ALL |
|
/morph test |
|
[Build ${MBED_BUILD_ID}] |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 789 All builds and test passed! |
| { | ||
| // Check if we've connected | ||
| if (!lwip_get_ip_address()) { | ||
| return NSAPI_ERROR_PARAMETER; |
There was a problem hiding this comment.
Isn't this supposed to be return NSAPI_ERROR_NO_CONNECTION (like below)?
There was a problem hiding this comment.
It could be, there's not much precedent here that I am aware of.
I chose NSAPI_ERROR_PARAMETER to match the error on connecting an already connected network interface (L148). Disconnecting an already disconnected interface is more a user error than a network error. Do you think this should be NSAPI_ERROR_NO_CONNECTION?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues #2439, #2421, #2445