RTOS - Move per-target RTX config to mbed_rtx.h #2586

tung7970 · 2016-08-30T16:47:32Z

Disintegrate global RTX target config. Move per-target fragment
to mbed_rtx.h under each vendor's directory.

Right now, only one mbed_rtx.h is defined for each vendor, but the granularity of mbed_rtx.h can be per-chip, or per-board if necessary.

sg- · 2016-09-09T21:46:18Z

This is great! Why are there json changes for MTS targets in the change set?

sg- · 2016-09-09T21:46:32Z

@tung7970 please rebase

tung7970 · 2016-09-10T00:58:42Z

A couple of MTS boards set OS_CLOCK through targets.json file. Move that to mbed_rtx.h so all related config stay at the same place.

Commit is rebased and pushed upstream. Thanks.

tung7970 · 2016-09-11T09:18:41Z

Rebased again for disco_f769ni and NUC472 merges.

sg- · 2016-09-11T12:37:05Z

@c1728p9 please review

c1728p9 · 2016-09-11T18:30:53Z

This looks good to me!

c1728p9 · 2016-09-12T14:55:38Z

/morph test

c1728p9 · 2016-09-12T14:55:57Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-09-12T15:57:14Z

[Build 912]
FAILURE: Something went wrong when building and testing.

bridadan · 2016-09-12T16:37:11Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-09-12T18:47:33Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 837

Build failed!

bridadan · 2016-09-12T18:55:01Z

Log from the build failure (note that I've shortened some of the output):

12:44:11 Build failures:
12:44:11   * NUMAKER_PFM_NUC472::ARM::MBED-BUILD
12:44:11         Building library mbed-build (NUMAKER_PFM_NUC472, ARM)
12:44:11         Scan: 507
12:44:11         Scan: FEATURE_BLE
12:44:11         Scan: FEATURE_CLIENT
12:44:11         Scan: FEATURE_COMMON_PAL
12:44:11         Scan: FEATURE_UVISOR
12:44:11         Scan: FEATURE_IPV4
12:44:11         Scan: FEATURE_IPV6
12:44:11         Scan: FEATURE_STORAGE
12:44:11         Copy: greentea_serial.h
12:44:11         Copy: test_env.h
12:44:11         Copy: unity.h
12:44:11         Copy: unity_config.h
[... SNIP ...]
12:44:11         Compile: HAL_CM.c
12:44:11         Compile: nu_modutil.c
12:44:11         Compile: RTX_Conf_CM.c
12:44:11         [Error] RTX_CM_lib.h@395,0:  #35: #error directive: "no target defined"

The target NUMAKER_PFM_NUC472 is failing to build for ARM, GCC_ARM, and IAR

mbed-bot · 2016-09-13T01:50:32Z

[Build 916]
FAILURE: Something went wrong when building and testing.

tung7970 · 2016-09-13T03:53:43Z

NUC472 defines HEAP_START and HEAP_SIZE directly. Modified target test to check for INITIAL_SP or HEAP_START.

tung7970 · 2016-09-14T07:55:43Z

Rebased for TARGET_STM32F030R8 RTOS support removal.

tung7970 · 2016-09-14T11:38:11Z

Rebased for TARGET_UBLOX_C029 merge.

tung7970 · 2016-09-17T03:10:46Z

Did a quick fix by moving the target check after ICCARM sets the HEAP_START.

sg- · 2016-09-17T17:39:27Z

/morph test

mbed-bot · 2016-09-17T18:49:37Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 886

All builds and test passed!

sg- · 2016-09-17T19:05:10Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-09-17T20:38:13Z

[Build 943]
FAILURE: Something went wrong when building and testing.

sg- · 2016-09-18T17:40:50Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

mbed-bot · 2016-09-18T19:26:32Z

[Build 946]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

sg- · 2016-09-18T22:46:15Z

@tung7970 Can you rebase and resolve the conflicts. Ready to come in after that.

tung7970 · 2016-09-19T01:03:08Z

Rebased and pushed. Thanks.

0xc0170

Nitpick: preprocessor directives should start at the beginning (see coding guide)

Other than that, good work !

tung7970 · 2016-09-20T09:28:38Z

Thanks for the reminder. Pushed a new commit with leading spaces removed.

sg- · 2016-09-22T05:45:47Z

@tung7970 Can you rebase and resolve the conflicts. Ready to come in after that. Last time :)

Disintegrate global RTX target config. Move per-target fragment to mbed_rtx.h under each vendor's directory. One mbed_rtx.h is defined for each vendor at this moment, however, the granularity of mbed_rtx.h can be per-chip, or per-board if necessary. Signed-off-by: Tony Wu <[email protected]>

tung7970 · 2016-09-22T07:11:21Z

Rebased and pushed. Thanks.

0xc0170 · 2016-09-22T08:45:56Z

/morph test

mbed-bot · 2016-09-22T18:27:46Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 924

All builds and test passed!

tung7970 force-pushed the feature-rtx-config branch 2 times, most recently from 06dfd18 to 8bcde6b Compare August 31, 2016 03:05

0xc0170 added the needs: review label Aug 31, 2016

tung7970 force-pushed the feature-rtx-config branch from 8bcde6b to 3eb832f Compare September 6, 2016 07:14

sg- added the needs: work label Sep 9, 2016

tung7970 force-pushed the feature-rtx-config branch from 3eb832f to 4c3e0a5 Compare September 10, 2016 00:50

sg- added needs: CI and removed needs: work labels Sep 10, 2016

tung7970 force-pushed the feature-rtx-config branch from 4c3e0a5 to be8b404 Compare September 11, 2016 09:17

tung7970 force-pushed the feature-rtx-config branch from be8b404 to 46b01c7 Compare September 13, 2016 03:29

tung7970 force-pushed the feature-rtx-config branch from 46b01c7 to c5a5f1b Compare September 14, 2016 07:54

tung7970 force-pushed the feature-rtx-config branch from c5a5f1b to 7bafdf4 Compare September 14, 2016 11:37

tung7970 force-pushed the feature-rtx-config branch from 7bafdf4 to a7b28f0 Compare September 14, 2016 11:55

sg- removed the needs: review label Sep 15, 2016

tung7970 force-pushed the feature-rtx-config branch from a7b28f0 to 0cb1b29 Compare September 17, 2016 02:56

sg- added needs: CI and removed needs: work labels Sep 17, 2016

sg- added ready for merge and removed needs: CI labels Sep 18, 2016

tung7970 force-pushed the feature-rtx-config branch from 0cb1b29 to c125675 Compare September 19, 2016 01:02

0xc0170 requested changes Sep 20, 2016

View reviewed changes

tung7970 force-pushed the feature-rtx-config branch 3 times, most recently from edc851b to ef5a590 Compare September 20, 2016 09:22

tung7970 force-pushed the feature-rtx-config branch from ef5a590 to aa663ea Compare September 22, 2016 07:10

0xc0170 approved these changes Sep 22, 2016

View reviewed changes

sg- merged commit f0c00bf into ARMmbed:master Sep 23, 2016

sg- added release-version: 5.2.0 and removed ready for merge labels Sep 23, 2016

RTOS - Move per-target RTX config to mbed_rtx.h #2586

RTOS - Move per-target RTX config to mbed_rtx.h #2586

Uh oh!

Conversation

tung7970 commented Aug 30, 2016

Uh oh!

sg- commented Sep 9, 2016

Uh oh!

sg- commented Sep 9, 2016

Uh oh!

tung7970 commented Sep 10, 2016

Uh oh!

tung7970 commented Sep 11, 2016

Uh oh!

sg- commented Sep 11, 2016

Uh oh!

c1728p9 commented Sep 11, 2016

Uh oh!

c1728p9 commented Sep 12, 2016

Uh oh!

c1728p9 commented Sep 12, 2016

Uh oh!

mbed-bot commented Sep 12, 2016

Uh oh!

bridadan commented Sep 12, 2016

Uh oh!

mbed-bot commented Sep 12, 2016

Result: FAILURE

Output

Uh oh!

bridadan commented Sep 12, 2016

Uh oh!

mbed-bot commented Sep 13, 2016

Uh oh!

tung7970 commented Sep 13, 2016

Uh oh!

tung7970 commented Sep 14, 2016

Uh oh!

tung7970 commented Sep 14, 2016

Uh oh!

tung7970 commented Sep 17, 2016

Uh oh!

sg- commented Sep 17, 2016

Uh oh!

mbed-bot commented Sep 17, 2016

Result: SUCCESS

Output

Uh oh!

sg- commented Sep 17, 2016

Uh oh!

mbed-bot commented Sep 17, 2016

Uh oh!

sg- commented Sep 18, 2016

Uh oh!

mbed-bot commented Sep 18, 2016

Uh oh!

sg- commented Sep 18, 2016

Uh oh!

tung7970 commented Sep 19, 2016

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

tung7970 commented Sep 20, 2016

Uh oh!

sg- commented Sep 22, 2016

Uh oh!

tung7970 commented Sep 22, 2016

Uh oh!

0xc0170 commented Sep 22, 2016

Uh oh!

mbed-bot commented Sep 22, 2016

Result: SUCCESS

Output

Uh oh!

Uh oh!