Skip to content

correct SPI pinmap typo #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2014
Merged

correct SPI pinmap typo #259

merged 3 commits into from
Apr 11, 2014

Conversation

sg-
Copy link
Contributor

@sg- sg- commented Apr 9, 2014

Enable error messages on K64F. Remove line ending from all SDK platform error calls. Patches necessary and line ending removal is for style guildance

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2014

Sam,
You added that newline only to Freescale target? I believe all of targets have the same problem.

Why did you remove PTD2/3 from SPI for K64F?

@mbednotifications
Copy link

They we're duplicate entries. Other targets need the same \n. Only can do
so much find and replace at a time.

Sam

On Wednesday, April 9, 2014, Martin Kojtal [email protected] wrote:

Sam,
You added that newline only to Freescale target? I believe all of targets
have the same problem.

Why did you remove PTD2/3 from SPI for K64F?

Reply to this email directly or view it on GitHubhttps://github.com//pull/259#issuecomment-39954725
.

You received this message because you are subscribed to the Google Groups
"mbed-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected]javascript:_e(%7B%7D,'cvml','mbed-devel%[email protected]');
.
For more options, visit https://groups.google.com/d/optout.

@sg-
Copy link
Contributor Author

sg- commented Apr 9, 2014

Dont accept this yet. I have one more commit that will come later to fix error according to C99 standard

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2014

@bogdanm, we had a discussion with Sam. As a result, the proposal would be to add flushing all output streams in the exit implementation. The C standard says in the 7.19.3 Files:

7- "The file may be subsequently reopened, by the same or another program execution, and
its contents reclaimed or modified (if it can be repositioned at its start). If the main
function returns to its original caller, or if the exit function is called, all open files are
closed (hence all output streams are flushed) before program termination. Other paths to
program termination, such as calling the abort function, need not close all files
properly."

5- "At program startup, three text streams are predefined and need not be opened explicitly
— standard input (for reading conventional input), standard output (for writing
conventional output), and standard error (for writing diagnostic output). As initially
opened, the standard error stream is not fully buffered; the standard input and standard
output streams are fully buffered if and only if the stream can be determined not to refer
to an interactive device."

Regards,
0xc0170

enable DEVICE_STDIO_MESSAGES on k64f
remove all line endings from error messages throughout mbed sdk (all targets)
@sg-
Copy link
Contributor Author

sg- commented Apr 9, 2014

OK - now added fflush for stderr and stdout to exit and make line endings consistent across all SDK for style guidance. Please merge unless there is a question or concern

@bogdanm bogdanm merged commit b64e322 into ARMmbed:master Apr 11, 2014
@bogdanm
Copy link
Contributor

bogdanm commented Apr 11, 2014

Manually merged. Note that the line endings are still inconsistent ('\n' in some places, '\r\n' in others), but this is a good step in the right direction.

bridadan pushed a commit that referenced this pull request Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants